From: Igor Russkikh <irusskikh@marvell.com>
To: "Ramsay, Lincoln" <Lincoln.Ramsay@digi.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
"Dmitry Bogdanov [C]" <dbogdanov@marvell.com>
Subject: Re: [EXT] [PATCH] aquantia: Remove the build_skb path
Date: Fri, 20 Nov 2020 10:52:58 +0300 [thread overview]
Message-ID: <12fbca7a-86c9-ab97-d052-2a5cb0a4f145@marvell.com> (raw)
In-Reply-To: <CY4PR1001MB2311E1B5D8E2700C92E7BE2DE8E00@CY4PR1001MB2311.namprd10.prod.outlook.com>
On 20/11/2020 1:01 am, Ramsay, Lincoln wrote:
> External Email
>
> ----------------------------------------------------------------------
> The build_skb path fails to allow for an SKB header, but the hardware
> buffer it is built around won't allow for this anyway.
>
> Just always use the slower codepath that copies memory into an
> allocated SKB.
>
> Signed-off-by: Lincoln Ramsay <lincoln.ramsay@opengear.com>
Acked-by: Igor Russkikh <irusskikh@marvell.com>
Yep, that could be the only way to fix this for now.
Have you tried to estimate any performance drops from this?
The most harm may be here on smaller packets, for stuff like UDP.
Regards,
Igor
next prev parent reply other threads:[~2020-11-20 7:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 1:52 [PATCH] aquantia: Reserve space when allocating an SKB Ramsay, Lincoln
2020-11-18 14:02 ` [EXT] " Igor Russkikh
2020-11-19 0:14 ` Ramsay, Lincoln
2020-11-19 5:19 ` Ramsay, Lincoln
2020-11-19 22:01 ` [PATCH] aquantia: Remove the build_skb path Ramsay, Lincoln
2020-11-19 22:07 ` [PATCH v2] " Ramsay, Lincoln
2020-11-19 22:15 ` Florian Westphal
2020-11-19 22:24 ` Ramsay, Lincoln
2020-11-19 22:28 ` Florian Westphal
2020-11-19 22:34 ` [PATCH v3] " Ramsay, Lincoln
2020-11-19 22:49 ` Maciej Fijalkowski
2020-11-20 8:18 ` [EXT] " Igor Russkikh
2020-11-23 19:28 ` Maciej Fijalkowski
2020-11-24 15:26 ` Igor Russkikh
2020-11-19 22:58 ` Florian Westphal
2020-11-19 23:52 ` [PATCH v4] " Ramsay, Lincoln
2020-11-20 0:17 ` Florian Westphal
2020-11-20 0:23 ` Ramsay, Lincoln
2020-11-21 21:22 ` Jakub Kicinski
2020-11-21 21:23 ` Jakub Kicinski
2020-11-22 22:36 ` Ramsay, Lincoln
2020-11-23 16:42 ` Jakub Kicinski
2020-11-23 21:40 ` [PATCH net v5] " Ramsay, Lincoln
2020-11-24 19:02 ` Jakub Kicinski
2020-11-22 21:55 ` [PATCH v4] " Ramsay, Lincoln
2020-11-20 7:52 ` Igor Russkikh [this message]
2020-11-23 4:20 ` [EXT] [PATCH] " Ramsay, Lincoln
2020-11-24 14:29 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12fbca7a-86c9-ab97-d052-2a5cb0a4f145@marvell.com \
--to=irusskikh@marvell.com \
--cc=Lincoln.Ramsay@digi.com \
--cc=davem@davemloft.net \
--cc=dbogdanov@marvell.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).