netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@tredhat.com,
	sassmann@redhat.com, Russell King <linux@arm.linux.org.uk>,
	aris@cathedrallabs.org, Donald Becker <becker@scyld.com>,
	Chris Beauregard <cpbeaure@undergrad.math.uwaterloo.ca>,
	Richard Procter <rnp@paradise.net.nz>,
	Andries Brouwer <aeb@cwi.nl>,
	"M.Hipp" <hippm@informatik.uni-tuebingen.de>,
	Richard Hirst <richard@sleepie.demon.co.uk>,
	Sam Creasey <sammy@oh.verio.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [net-next 10/10] i825xx: Move the Intel 82586/82593/82596 based drivers
Date: Thu, 11 Aug 2011 12:04:55 +0100	[thread overview]
Message-ID: <1313060697.6733.111.camel@phil-desktop> (raw)
In-Reply-To: <1313033278-7337-11-git-send-email-jeffrey.t.kirsher@intel.com>

On Wed, 2011-08-10 at 20:27 -0700, Jeff Kirsher wrote:
> Move the drivers that use the i82586/i82593/i82596 chipsets into
> drivers/net/ethernet/i825xx/ and make the necessary Kconfig and
> Makefile changes.  There were 4 3Com drivers which were initially
> moved into 3com/, which now reside in i825xx since they all used
> the i82586 chip.

Actually, I think 3c505 was better in 3com/ where you had it before.
Although the card does use an i82586, it's front-ended by an 80186
microcontroller and that's what the driver talks to.  So there is no
meaningful code commonality with the other '586 drivers.

That said, I don't think it's a massive deal either way and if you have
a strong preference for putting it in i825xx then that's probably fine.

p.



  reply	other threads:[~2011-08-11 11:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11  3:27 [net-next 00/10] drivers/net/ organize Ethernet drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 01/10] drivers/net/ethernet: Add ethernet dir and config option Jeff Kirsher
2011-08-11  3:27 ` [net-next 02/10] 3c*/acenic/typhoon: Move 3Com Ethernet drivers Jeff Kirsher
2011-08-11  9:02   ` Alan Cox
2011-08-11  9:13     ` Jeff Kirsher
2011-08-11  9:58       ` Alan Cox
2011-08-11 10:07         ` Jeff Kirsher
2011-08-11  3:27 ` [net-next 03/10] amd: Move AMD (Lance) chipset drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 04/10] 8390: Move the 8390 related drivers Jeff Kirsher
2011-08-11 13:07   ` Ben Hutchings
2011-08-11  3:27 ` [net-next 05/10] broadcom: Move the Broadcom drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 06/10] chelsio: Move the Chelsio drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 07/10] intel: Move the Intel wired LAN drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 08/10] qlogic: Move the QLogic drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 09/10] smsc: Move the SMC (SMSC) drivers Jeff Kirsher
2011-08-11  3:27 ` [net-next 10/10] i825xx: Move the Intel 82586/82593/82596 based drivers Jeff Kirsher
2011-08-11 11:04   ` Phil Blundell [this message]
2011-08-11  5:08 ` [net-next 00/10] drivers/net/ organize Ethernet drivers David Miller
2011-08-11  5:24   ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313060697.6733.111.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=aeb@cwi.nl \
    --cc=aris@cathedrallabs.org \
    --cc=becker@scyld.com \
    --cc=cpbeaure@undergrad.math.uwaterloo.ca \
    --cc=davem@davemloft.net \
    --cc=gospo@tredhat.com \
    --cc=hippm@informatik.uni-tuebingen.de \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=richard@sleepie.demon.co.uk \
    --cc=rnp@paradise.net.nz \
    --cc=sammy@oh.verio.com \
    --cc=sassmann@redhat.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).