On Thu, 2011-08-11 at 11:41 +0800, hayeswang wrote: > > > -----Original Message----- > > From: Ben Hutchings [mailto:ben@decadent.org.uk] > > > +File: rtl_nic/rtl8168e-3.fw (Version: rtl8168e-3_0.0.1) > > [...] > > > > Please don't write the version in yet another way. It should be: > > > > I just think if someone replaces the firmware with another one, I could check > the firmware through the information without checking the ram data. > For example, someone renames the rtl8168f-1.fw to rtl8168e-3.fw and replaces the > original rtl8168e-3.fw. Through ethtool to show the version of the firmware, I > could know the firmware is invalid. If the version only contain the value 0.0.1, > I must compare the binary file to find out the result. [...] You're talking about the version string inside the firmware file. I see the value of including the name there. However, in the WHENCE file it is redundant. But I really don't care that much. Ben.