From: Eric Dumazet <eric.dumazet@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Ben Hutchings <bhutchings@solarflare.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: >Re: [RFC] should VM_BUG_ON(cond) really evaluate cond
Date: Sun, 30 Oct 2011 18:41:34 +0100 [thread overview]
Message-ID: <1319996494.13597.69.camel@edumazet-laptop> (raw)
In-Reply-To: <CA+55aFyGEhBMv31QXN7q9PJc36TVtHLOvdFYB1+6NTo+nKSkbQ@mail.gmail.com>
Le dimanche 30 octobre 2011 à 10:07 -0700, Linus Torvalds a écrit :
> On Sun, Oct 30, 2011 at 8:16 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> > Because it doesnt work if x is const.
>
> Just remove the const. Problem solved.
>
> Both cases of 'const' are totally arbitrary and useless. The
> test_bit() one is literally a cast to const (admittedly also *from*
> const, but nobody cares), and the atomic_read() one is just because it
> uses a silly inline function where a macro would be simpler.
>
Oh well, I am lost. I always considered inline functione better because
of prototype checks.
Changing atomic_read(const atomic_t *v) prototype to
atomic_read(atomic_t *v) is not an option.
To save your time and my time, please select your favorite between :
1) The patch I did
2)
static inline int atomic_read(const atomic_t *v)
{
return ACCESS_AT_MOST_ONCE(((atomic_t *)v)->counter);
}
3)
static inline int atomic_read(const atomic_t *v)
{
return ACCESS_AT_MOST_ONCE(*(int *)&(v)->counter);
}
4) macro (I personnaly dont like it)
#define atomic_read(v) ACCESS_AT_MOST_ONCE(*(int *)&(v)->counter)
Thanks
next prev parent reply other threads:[~2011-10-30 17:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 1:19 [RFC] should VM_BUG_ON(cond) really evaluate cond Eric Dumazet
2011-10-28 1:25 ` Andi Kleen
2011-10-28 1:34 ` Linus Torvalds
2011-10-28 1:44 ` Ben Hutchings
2011-10-28 2:52 ` Eric Dumazet
2011-10-28 3:29 ` Ben Hutchings
2011-10-28 4:43 ` >Re: " Eric Dumazet
2011-10-28 11:37 ` Linus Torvalds
2011-10-28 12:09 ` Eric Dumazet
2011-10-28 12:19 ` Linus Torvalds
2011-10-28 12:40 ` Linus Torvalds
2011-10-28 14:47 ` Eric Dumazet
2011-10-28 14:55 ` Linus Torvalds
2011-10-29 15:43 ` Eric Dumazet
2011-10-29 17:34 ` Linus Torvalds
2011-10-30 8:52 ` Eric Dumazet
2011-10-30 9:59 ` Andi Kleen
2011-10-30 15:16 ` Eric Dumazet
2011-10-30 17:07 ` Linus Torvalds
2011-10-30 17:41 ` Eric Dumazet [this message]
2011-10-30 17:48 ` Linus Torvalds
2011-10-30 17:59 ` Eric Dumazet
2011-10-30 18:09 ` Linus Torvalds
2011-11-02 0:14 ` Eric Dumazet
2011-11-01 4:06 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319996494.13597.69.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bhutchings@solarflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).