From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <jeffrey.t.kirsher@intel.com>, <bruce.w.allan@intel.com>,
<netdev@vger.kernel.org>, <gospo@redhat.com>,
<sassmann@redhat.com>
Subject: Re: [net-next 07/11] e1000e: cleanup Rx checksum offload code
Date: Tue, 3 Jan 2012 21:24:02 +0000 [thread overview]
Message-ID: <1325625842.2832.17.camel@bwh-desktop> (raw)
In-Reply-To: <20120103.161553.395980097965998086.davem@davemloft.net>
On Tue, 2012-01-03 at 16:15 -0500, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Tue, 3 Jan 2012 21:00:12 +0000
>
> > On Tue, 2012-01-03 at 15:08 -0500, David Miller wrote:
> >> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> >> Date: Tue, 3 Jan 2012 11:19:12 -0800
> >>
> >> > - __sum16 sum = (__force __sum16)htons(csum);
> >> > + __sum16 sum = (__force __sum16)htons(le16_to_cpu(csum));
> >>
> >> Looks like a NOP. It's essentially "cpu_to_le16(le16_to_cpu(csum)" as
> >> far as I can tell.
> >
> > Looks like a swab() to me...
>
> I don't see how it can be. It's effectively doing a 16-bit swap and
> then a 16-bit swap again, which is a NOP.
>
> It's the same as "(__force __sum16) csum" and I bet if the code above
> works, then this expression I'm suggesting will work too.
In this part of the universe, network order is big-endian.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-01-03 21:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 19:19 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-01-03 19:19 ` [net-next 01/11] e1000: fix lockdep splat in shutdown handler Jeff Kirsher
2012-01-03 19:19 ` [net-next 02/11] igb: Add support for byte queue limits Jeff Kirsher
2012-01-03 19:19 ` [net-next 03/11] igb: add basic runtime PM support Jeff Kirsher
2012-01-03 19:19 ` [net-next 04/11] igb: reset PHY after recovering from PHY power down Jeff Kirsher
2012-01-03 19:19 ` [net-next 05/11] netdev: FCoE: Add new ndo_get_fcoe_hbainfo() call Jeff Kirsher
2012-01-03 20:07 ` David Miller
2012-01-03 20:53 ` Parikh, Neerav
2012-01-03 19:19 ` [net-next 06/11] ixgbe: FCoE: Add support for " Jeff Kirsher
2012-01-03 19:19 ` [net-next 07/11] e1000e: cleanup Rx checksum offload code Jeff Kirsher
2012-01-03 20:08 ` David Miller
2012-01-03 20:17 ` Allan, Bruce W
2012-01-03 21:00 ` Ben Hutchings
2012-01-03 21:15 ` David Miller
2012-01-03 21:24 ` Ben Hutchings [this message]
2012-01-03 22:02 ` David Miller
2012-01-03 19:19 ` [net-next 08/11] e1000e: add Receive Packet Steering (RPS) support Jeff Kirsher
2012-01-03 20:09 ` David Miller
2012-01-03 20:16 ` Allan, Bruce W
2012-01-03 20:27 ` David Miller
2012-01-03 20:28 ` Allan, Bruce W
2012-01-04 0:12 ` Joe Perches
2012-01-04 2:06 ` Harvey Harrison
2012-01-03 21:05 ` Ben Hutchings
2012-01-06 17:22 ` Allan, Bruce W
2012-01-06 17:31 ` Ben Hutchings
2012-01-03 19:19 ` [net-next 09/11] e1000e: re-enable alternate MAC address for all devices which support it Jeff Kirsher
2012-01-03 19:19 ` [net-next 10/11] e1000e: convert head, tail and itr_register offsets to __iomem pointers Jeff Kirsher
2012-01-03 19:19 ` [net-next 11/11] e1000e: pass pointer to ring struct instead of adapter struct Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325625842.2832.17.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).