From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: steweg@ynet.sk, gregory.v.rose@intel.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch v1, kernel version 3.2.1] rtnetlink workaround around the skb buff size issue
Date: Mon, 06 Feb 2012 17:56:06 +0100 [thread overview]
Message-ID: <1328547366.2220.83.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <20120206.101517.1598607878740481170.davem@davemloft.net>
Le lundi 06 février 2012 à 10:15 -0500, David Miller a écrit :
> From: Štefan Gula <steweg@ynet.sk>
> Date: Mon, 6 Feb 2012 09:53:28 +0100
>
> > If I try to request for it, it will eventually fail with a lot of
> > records even with filtering...
>
> Then the user can loop increasing the buffer size until the netlink
> request succeeds.
>
> It is not a problem.
Actually we always truncate message in netlink_recvmsg()
We could use a MSG_NOPARTIAL flag in netlink_recvmsg() so that user can
avoid the MSG_PEEK operation to fetch next message length.
(Ie not consume/copy skb if user buffer is too small to hold full
message, and only return the needed length)
next prev parent reply other threads:[~2012-02-06 16:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5422254.3711328278789768.JavaMail.root@5-MeO-DMT.ynet.sk>
2012-02-03 14:24 ` [patch v1, kernel version 3.2.1] rtnetlink workaround around the skb buff size issue Stefan Gula
2012-02-04 0:29 ` David Miller
2012-02-06 4:41 ` Rose, Gregory V
2012-02-06 8:53 ` Štefan Gula
2012-02-06 15:15 ` David Miller
2012-02-06 16:56 ` Eric Dumazet [this message]
2012-02-06 18:52 ` Štefan Gula
2012-02-06 17:29 ` Rose, Gregory V
2012-02-06 18:32 ` Štefan Gula
2012-02-06 18:36 ` Rose, Gregory V
2012-02-06 23:50 ` Ben Hutchings
2012-02-07 0:13 ` Rose, Gregory V
2012-02-07 18:26 ` Ben Hutchings
2012-02-07 18:32 ` David Miller
2012-02-07 18:59 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328547366.2220.83.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steweg@ynet.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).