netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Erich E. Hoover" <ehoover@mines.edu>
Cc: Linux Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] Implement IP_UNICAST_IF socket option.
Date: Wed, 08 Feb 2012 08:21:57 +0100	[thread overview]
Message-ID: <1328685717.4736.4.camel@edumazet-laptop> (raw)
In-Reply-To: <1328651073-976-1-git-send-email-ehoover@mines.edu>

Le mardi 07 février 2012 à 14:44 -0700, Erich E. Hoover a écrit :
> The IP_UNICAST_IF feature is needed by the Wine project.  This patch implements the feature by setting the outgoing interface in a similar fashion to that of IP_MULTICAST_IF.  A separate option is needed to handle this feature since the existing options do not provide all of the characteristics required by IP_UNICAST_IF, a summary is provided below.
> 
> SO_BINDTODEVICE:
> * SO_BINDTODEVICE requires administrative privileges, IP_UNICAST_IF does not.  From reading some old mailing list articles my understanding is that SO_BINDTODEVICE requires administrative privileges because it can override the administrator's routing settings.
> * The SO_BINDTODEVICE option restricts both outbound and inbound traffic, IP_UNICAST_IF only impacts outbound traffic.
> 
> IP_PKTINFO:
> * Since IP_PKTINFO and IP_UNICAST_IF are independent options, implementing IP_UNICAST_IF with IP_PKTINFO will likely break some applications.
> * Implementing IP_UNICAST_IF on top of IP_PKTINFO significantly complicates the Wine codebase and reduces the socket performance (doing this requires a lot of extra communication between the "server" and "user" layers).
> 
> bind():
> * bind() does not work on broadcast packets, IP_UNICAST_IF is specifically intended to work with broadcast packets.
> * Like SO_BINDTODEVICE, bind() restricts both outbound and inbound traffic.
> 
> Signed-off-by: Erich E. Hoover <ehoover@mines.edu>

This seems good, only the changelog is not formatted to fit in short
lines (70 cols)

Also title should include subsystem name  :

ipv4: Implement IP_UNICAST_IF socket option.

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

  reply	other threads:[~2012-02-08  7:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 21:44 Erich E. Hoover
2012-02-08  7:21 ` Eric Dumazet [this message]
     [not found] <62162DF05402B341B3DB59932A1FA992B5B5D1FC8A@EUSAACMS0702.eamcs.ericsson.se>
2012-02-08  1:10 ` Erich E. Hoover
2012-02-08  6:25   ` Shawn Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328685717.4736.4.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=ehoover@mines.edu \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v6 1/2] Implement IP_UNICAST_IF socket option.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).