From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: "Yuval Mintz" <yuvalmin@broadcom.com>,
"Eilon Greenstein" <eilong@broadcom.com>
Subject: [net-next 7/8] bnx2x: ethtool returns req. AN even when AN fails
Date: Mon, 12 Mar 2012 14:53:13 -0400 [thread overview]
Message-ID: <1331578394-1153-8-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1331578394-1153-1-git-send-email-yuvalmin@broadcom.com>
Previously, if autoneg failed, ethtool would return the achieved autoneg.
This patch corrects this, causing ethtool to return the requested autoneg
capabilities even if autoneg fails.
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
.../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 8f8421d..858d1b5 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -1450,7 +1450,7 @@ static void bnx2x_get_pauseparam(struct net_device *dev,
BNX2X_FLOW_CTRL_AUTO);
if (!epause->autoneg)
- cfg_reg = bp->link_vars.flow_ctrl;
+ cfg_reg = bp->link_params.req_flow_ctrl[cfg_idx];
else
cfg_reg = bp->link_params.req_fc_auto_adv;
--
1.7.9.rc2
next prev parent reply other threads:[~2012-03-12 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 18:53 [net-next 0/8] bnx2x feature patch series Yuval Mintz
2012-03-12 18:53 ` [net-next 1/8] bnx2x: move LLH_CAM to header, apply naming conventions Yuval Mintz
2012-03-12 18:53 ` [net-next 2/8] bnx2x: removed unused function bnx2x_queue_set_cos_cid Yuval Mintz
2012-03-12 18:53 ` [net-next 3/8] bnx2x: set_one_mac_e1x uses raw's state as input Yuval Mintz
2012-03-12 18:53 ` [net-next 4/8] bnx2x: use param's id instead of sp_obj's id Yuval Mintz
2012-03-12 18:53 ` [net-next 5/8] bnx2x: mark functions as loaded on shared memory Yuval Mintz
2012-03-12 18:53 ` [net-next 6/8] bnx2x: ethtool now returns unknown speed/duplex Yuval Mintz
2012-03-12 18:53 ` Yuval Mintz [this message]
2012-03-12 18:53 ` [net-next 8/8] bnx2x: code doesn't use stats for allocating Rx BDs Yuval Mintz
2012-03-13 0:11 ` [net-next 0/8] bnx2x feature patch series David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331578394-1153-8-git-send-email-yuvalmin@broadcom.com \
--to=yuvalmin@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).