From: Eric Dumazet <eric.dumazet@gmail.com>
To: Kieran Mansley <kmansley@solarflare.com>
Cc: netdev@vger.kernel.org
Subject: Re: TCPBacklogDrops during aggressive bursts of traffic
Date: Tue, 15 May 2012 17:00:25 +0200 [thread overview]
Message-ID: <1337094025.8512.1095.camel@edumazet-glaptop> (raw)
In-Reply-To: <1337093776.8512.1089.camel@edumazet-glaptop>
On Tue, 2012-05-15 at 16:56 +0200, Eric Dumazet wrote:
> Please try latest kernels, this is probably 'fixed'
>
> What network driver are you using ?
>
>
commit b49960a05e32121d29316cfdf653894b88ac9190
Author: Eric Dumazet <edumazet@google.com>
Date: Wed May 2 02:28:41 2012 +0000
tcp: change tcp_adv_win_scale and tcp_rmem[2]
tcp_adv_win_scale default value is 2, meaning we expect a good citizen
skb to have skb->len / skb->truesize ratio of 75% (3/4)
In 2.6 kernels we (mis)accounted for typical MSS=1460 frame :
1536 + 64 + 256 = 1856 'estimated truesize', and 1856 * 3/4 = 1392.
So these skbs were considered as not bloated.
With recent truesize fixes, a typical MSS=1460 frame truesize is now the
more precise :
2048 + 256 = 2304. But 2304 * 3/4 = 1728.
So these skb are not good citizen anymore, because 1460 < 1728
(GRO can escape this problem because it build skbs with a too low
truesize.)
This also means tcp advertises a too optimistic window for a given
allocated rcvspace : When receiving frames, sk_rmem_alloc can hit
sk_rcvbuf limit and we call tcp_prune_queue()/tcp_collapse() too often,
especially when application is slow to drain its receive queue or in
case of losses (netperf is fast, scp is slow). This is a major latency
source.
We should adjust the len/truesize ratio to 50% instead of 75%
This patch :
1) changes tcp_adv_win_scale default to 1 instead of 2
2) increase tcp_rmem[2] limit from 4MB to 6MB to take into account
better truesize tracking and to allow autotuning tcp receive window to
reach same value than before. Note that same amount of kernel memory is
consumed compared to 2.6 kernels.
Signed-off-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-05-15 15:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:38 TCPBacklogDrops during aggressive bursts of traffic Kieran Mansley
2012-05-15 14:56 ` Eric Dumazet
2012-05-15 15:00 ` Eric Dumazet [this message]
2012-05-15 16:29 ` Kieran Mansley
2012-05-15 16:34 ` Eric Dumazet
2012-05-15 16:47 ` Ben Hutchings
2012-05-15 17:01 ` Eric Dumazet
2012-05-15 17:23 ` Eric Dumazet
2012-05-17 16:31 ` Kieran Mansley
2012-05-17 16:37 ` Eric Dumazet
2012-05-18 15:45 ` Kieran Mansley
2012-05-18 15:49 ` Eric Dumazet
2012-05-18 15:53 ` Kieran Mansley
2012-05-18 18:40 ` Eric Dumazet
2012-05-22 8:20 ` Kieran Mansley
2012-05-22 9:25 ` Eric Dumazet
2012-05-22 9:30 ` Eric Dumazet
2012-05-22 15:09 ` Kieran Mansley
2012-05-22 16:12 ` Eric Dumazet
2012-05-22 16:32 ` Kieran Mansley
2012-05-22 16:45 ` Eric Dumazet
2012-05-22 20:54 ` Eric Dumazet
2012-05-23 9:44 ` Eric Dumazet
2012-05-23 12:09 ` Eric Dumazet
2012-05-23 16:04 ` Alexander Duyck
2012-05-23 16:12 ` Eric Dumazet
2012-05-23 16:39 ` Eric Dumazet
2012-05-23 17:10 ` Alexander Duyck
2012-05-23 21:19 ` Alexander Duyck
2012-05-23 21:37 ` Eric Dumazet
2012-05-23 22:03 ` Alexander Duyck
2012-05-23 16:58 ` Alexander Duyck
2012-05-23 17:24 ` Eric Dumazet
2012-05-23 17:57 ` Alexander Duyck
2012-05-23 17:34 ` David Miller
2012-05-23 17:46 ` Eric Dumazet
2012-05-23 17:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337094025.8512.1095.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=kmansley@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).