From: Jamal Hadi Salim <jhs@mojatatu.com>
To: adam.niescierowicz@justnet.pl
Cc: netdev@vger.kernel.org
Subject: Re: tc filter u32 match
Date: Thu, 24 May 2012 06:04:38 -0400 [thread overview]
Message-ID: <1337853878.3513.11.camel@mojatatu> (raw)
In-Reply-To: <32a6182e71dd565206cf39d4cad3f984@justnet.pl>
On Tue, 2012-05-22 at 15:42 +0200, Nieścierowicz Adam wrote:
> Hello,
>
> I'm in the process of building a new shaper, when adding support for
> 802.1q
> vlan noticed that u32 can catch network traffic without giving 4 bytes
> offset. How is this possible?
>
Because we look at where the network header starts?
Why do you expect 4 bytes to be counted?
> My environment:
>
> eth2 - network card
> eth2.200 - vlan
>
> /sbin/tc filter add dev eth2 parent 1:0 prio 5 handle 35: protocol ip
> u32 divisor 256
> /sbin/tc filter add dev eth2 protocol ip parent 1:0 prio 5 u32 ht 800::
> match ip dst 31.41.208.32/27 hashkey mask 0x000000ff at 16 link 35:
> /sbin/tc filter add dev eth2 protocol ip parent 1: prio 1 u32 ht 35:24:
> match ip dst 31.41.208.36 flowid 1:2e5
>
> Here you can see the hits in the rule
> filter parent 1: protocol ip pref 5 u32 fh 35:24:800 order 2048 key ht
> 35 bkt 24 flowid 1:2e5 (rule hit 44037 success 44037)
> match 1f29d024/ffffffff at 16 (success 44037 )
I dont see an issue. This looks correct.
>
> I found a similar question here
> http://serverfault.com/questions/370795/tc-u32-how-to-match-l2-protocols-in-recent-kernels
>
There may have been bugs in the past that someone missed or didnt
report here (likely around the time there was a lot of changes
happening with vlan offloading). Try the latest kernel and
if it behaves badly, send a report and a reproducible test case.
cheers,
jamal
next prev parent reply other threads:[~2012-05-24 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 13:42 tc filter u32 match Nieścierowicz Adam
2012-05-24 10:04 ` Jamal Hadi Salim [this message]
2012-11-07 23:36 ` Nieścierowicz Adam
2012-05-22 13:45 Nieścierowicz Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337853878.3513.11.camel@mojatatu \
--to=jhs@mojatatu.com \
--cc=adam.niescierowicz@justnet.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).