From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Cross Subject: [PATCH v3 12/16] select: use freezable blocking call Date: Mon, 6 May 2013 16:50:17 -0700 Message-ID: <1367884221-20462-13-git-send-email-ccross@android.com> References: <1367884221-20462-1-git-send-email-ccross@android.com> Cc: Pavel Machek , "Rafael J. Wysocki" , Peter Zijlstra , Ingo Molnar , Andrew Morton , Mandeep Singh Baines , Colin Cross , Oleg Nesterov , linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , Tejun Heo , Alexander Viro , linux-fsdevel@vger.kernel.org To: linux-kernel@vger.kernel.org Return-path: Received: from mail-qe0-f74.google.com ([209.85.128.74]:56596 "EHLO mail-qe0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932497Ab3EFXuc (ORCPT ); Mon, 6 May 2013 19:50:32 -0400 Received: by mail-qe0-f74.google.com with SMTP id 1so447696qec.1 for ; Mon, 06 May 2013 16:50:31 -0700 (PDT) In-Reply-To: <1367884221-20462-1-git-send-email-ccross@android.com> Sender: netdev-owner@vger.kernel.org List-ID: Avoid waking up every thread sleeping in a select call during suspend and resume by calling a freezable blocking call. Previous patches modified the freezer to avoid sending wakeups to threads that are blocked in freezable blocking calls. This call was selected to be converted to a freezable call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Acked-by: Tejun Heo Signed-off-by: Colin Cross --- fs/select.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/select.c b/fs/select.c index 8c1c96c..6b14dc7 100644 --- a/fs/select.c +++ b/fs/select.c @@ -27,6 +27,7 @@ #include #include #include +#include #include @@ -236,7 +237,8 @@ int poll_schedule_timeout(struct poll_wqueues *pwq, int state, set_current_state(state); if (!pwq->triggered) - rc = schedule_hrtimeout_range(expires, slack, HRTIMER_MODE_ABS); + rc = freezable_schedule_hrtimeout_range(expires, slack, + HRTIMER_MODE_ABS); __set_current_state(TASK_RUNNING); /* -- 1.8.2.1