From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hauweele Subject: [PATCH 2/2] mrf24j40: Keep the interrupt line enabled Date: Thu, 9 May 2013 17:19:47 +0200 Message-ID: <1368112788-25701-2-git-send-email-david@hauweele.net> References: <1368112788-25701-1-git-send-email-david@hauweele.net> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Hauweele To: Alexander Smirnov , Dmitry Eremin-Solenikov , linux-zigbee-devel@lists.sourceforge.net Return-path: In-Reply-To: <1368112788-25701-1-git-send-email-david@hauweele.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Disabling the interrupt line could miss an IRQ and leave the line into a low state hence locking the driver. Signed-off-by: David Hauweele --- drivers/net/ieee802154/mrf24j40.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c index 1e3ddf3..6ef32f7 100644 --- a/drivers/net/ieee802154/mrf24j40.c +++ b/drivers/net/ieee802154/mrf24j40.c @@ -603,8 +603,6 @@ static irqreturn_t mrf24j40_isr(int irq, void *data) { struct mrf24j40 *devrec = data; - disable_irq_nosync(irq); - schedule_work(&devrec->irqwork); return IRQ_HANDLED; @@ -619,7 +617,7 @@ static void mrf24j40_isrwork(struct work_struct *work) /* Read the interrupt status */ ret = read_short_reg(devrec, REG_INTSTAT, &intstat); if (ret) - goto out; + return; /* Check for TX complete */ if (intstat & 0x1) @@ -628,9 +626,6 @@ static void mrf24j40_isrwork(struct work_struct *work) /* Check for Rx */ if (intstat & 0x8) schedule_work(&devrec->rxwork); - -out: - enable_irq(devrec->spi->irq); } static void mrf24j40_rxwork(struct work_struct *work) -- 1.7.10.4