netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rasesh Mody <rmody@brocade.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>,
	<adapter_linux_open_src_team@Brocade.COM>,
	Rasesh Mody <rmody@Brocade.COM>
Subject: [net-next v1 1/4] bna: Clear Driver Config Flags When HW Resets
Date: Mon, 20 May 2013 13:08:01 -0700	[thread overview]
Message-ID: <1369080484-29926-2-git-send-email-rmody@brocade.com> (raw)
In-Reply-To: <1369080484-29926-1-git-send-email-rmody@brocade.com>

Driver configuration flags are retained across open/stop operations preventing
configurations to be set in next open/stop. Setting MTU on a 1020 causes
network to fail until a reboot is performed on the host.

Clear the flags when configuration resets in hardware.

Signed-off-by: Rasesh Mody <rmody@brocade.com>
---
 drivers/net/ethernet/brocade/bna/bnad.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index ce4a030..a6c16a2 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -2624,6 +2624,9 @@ bnad_stop(struct net_device *netdev)
 	bnad_destroy_tx(bnad, 0);
 	bnad_destroy_rx(bnad, 0);
 
+	/* These config flags are cleared in the hardware */
+	bnad->cfg_flags &= ~(BNAD_CF_ALLMULTI | BNAD_CF_PROMISC);
+
 	/* Synchronize mailbox IRQ */
 	bnad_mbox_irq_sync(bnad);
 
-- 
1.7.1

  reply	other threads:[~2013-05-20 20:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 20:08 [net-next v1 0/4] Update the driver version to 3.2.21.1 Rasesh Mody
2013-05-20 20:08 ` Rasesh Mody [this message]
2013-05-20 20:08 ` [net-next v1 2/4] bna: Fix Ucast Failure Handling Rasesh Mody
2013-05-20 20:08 ` [net-next v1 3/4] bna: Enahncement to Identify Default IOC Function Rasesh Mody
2013-05-20 20:08 ` [net-next v1 4/4] bna: Driver and Firmware Updated Rasesh Mody
2013-05-20 21:08 ` [net-next v1 0/4] Update the driver version to 3.2.21.1 David Miller
  -- strict thread matches above, loose matches on Subject: below --
2013-05-13  5:05 Rasesh Mody
2013-05-13  5:05 ` [net-next v1 1/4] bna: Clear Driver Config Flags When HW Resets Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369080484-29926-2-git-send-email-rmody@brocade.com \
    --to=rmody@brocade.com \
    --cc=adapter_linux_open_src_team@Brocade.COM \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).