From: Wangyufen <wangyufen@huawei.com>
To: <netdev@vger.kernel.org>, <lizefan@huawei.com>
Cc: <zhangdianfang@huawei.com>
Subject: [PATCH v2] bonding:fix speed unknown,lacp bonding failed
Date: Tue, 9 Jul 2013 08:52:02 +0800 [thread overview]
Message-ID: <1373331122-10052-1-git-send-email-wangyufen@huawei.com> (raw)
From: "Wang Yufen" <wangyufen@huawei.com>
We bonded nic using LACP mode repeatedly, occasionally LACP bonding failed,
because a slave nic port speed was unknown. But when we used ethtool to
check the slave NIC status, the nic status was normal,speed was 10000Mb/s.
Bonding get the NIC speed from NIC drivers,just when enslave nic
and receive NETDEV_CHANGE event.We call bond_update_speed_duplex to
update speed and duplex when miimon inspect slave link is OK and slave
speed is unknown.
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/net/bonding/bond_main.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index f975696..4ccc173 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2301,8 +2301,22 @@ static int bond_miimon_inspect(struct bonding *bond)
switch (slave->link) {
case BOND_LINK_UP:
- if (link_state)
+ if (link_state) {
+ if (slave->speed == SPEED_UNKNOWN) {
+ rtnl_lock();
+ bond_update_speed_duplex(slave);
+ if (slave->speed != SPEED_UNKNOWN
+ && bond->params.mode
+ == BOND_MODE_8023AD) {
+ bond_3ad_adapter_speed_changed(
+ slave);
+ bond_3ad_adapter_duplex_changed(
+ slave);
+ }
+ rtnl_unlock();
+ }
continue;
+ }
slave->link = BOND_LINK_FAIL;
slave->delay = bond->params.downdelay;
--
1.8.0
next reply other threads:[~2013-07-09 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 0:52 Wangyufen [this message]
2013-07-09 1:42 ` [PATCH v2] bonding:fix speed unknown,lacp bonding failed Li Zefan
2013-07-09 13:43 ` [v2] " Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373331122-10052-1-git-send-email-wangyufen@huawei.com \
--to=wangyufen@huawei.com \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=zhangdianfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).