From: Ben Hutchings <bhutchings@solarflare.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: <gregkh@linuxfoundation.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH net 2/2] usb/net/r815x: fix cast to restricted __le32
Date: Mon, 15 Jul 2013 19:45:44 +0100 [thread overview]
Message-ID: <1373913944.3745.16.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <1373617576-2272-2-git-send-email-hayeswang@realtek.com>
On Fri, 2013-07-12 at 16:26 +0800, Hayes Wang wrote:
> >> drivers/net/usb/r815x.c:38:16: sparse: cast to restricted __le32
> >> drivers/net/usb/r815x.c:67:15: sparse: cast to restricted __le32
> >> drivers/net/usb/r815x.c:69:13: sparse: incorrect type in assignment (different base types)
> drivers/net/usb/r815x.c:69:13: expected unsigned int [unsigned] [addressable] [assigned] [usertype] tmp
> drivers/net/usb/r815x.c:69:13: got restricted __le32 [usertype] <noident>
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> Spotted-by: kbuild test robot <fengguang.wu@intel.com>
> ---
> drivers/net/usb/r815x.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/usb/r815x.c b/drivers/net/usb/r815x.c
> index 6516737..8523922 100644
> --- a/drivers/net/usb/r815x.c
> +++ b/drivers/net/usb/r815x.c
> @@ -26,16 +26,18 @@ static int pla_read_word(struct usb_device *udev, u16 index)
> {
> int data, ret;
> u8 shift = index & 2;
> + __le32 ocp_data;
>
> index &= ~3;
>
> ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
> RTL815x_REQ_GET_REGS, RTL815x_REQT_READ,
> - index, MCU_TYPE_PLA, &data, sizeof(data), 500);
> + index, MCU_TYPE_PLA, &ocp_data, sizeof(ocp_data),
> + 500);
[...]
There seems to be another bug here: USB buffers must be DMA-able,
therefore cannot be placed on the stack.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-07-15 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 8:26 [PATCH net 1/2] usb/net/r8152: fix integer overflow in expression Hayes Wang
2013-07-12 8:26 ` [PATCH net 2/2] usb/net/r815x: fix cast to restricted __le32 Hayes Wang
2013-07-12 23:14 ` David Miller
2013-07-15 18:45 ` Ben Hutchings [this message]
2013-07-12 23:13 ` [PATCH net 1/2] usb/net/r8152: fix integer overflow in expression David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373913944.3745.16.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).