From: Christoph Paasch <christoph.paasch@uclouvain.be> To: Stephen Hemminger <stephen@networkplumber.org> Cc: netdev@vger.kernel.org Subject: [PATCH iproute2 2/2] lnstat: Fix compiler errors of unused return-values Date: Sat, 20 Jul 2013 21:58:18 +0200 [thread overview] Message-ID: <1374350298-1177-3-git-send-email-christoph.paasch@uclouvain.be> (raw) In-Reply-To: <1374350298-1177-1-git-send-email-christoph.paasch@uclouvain.be> Many errors when compiling with gcc 4.7.3 about unused return-values upon the calls to fgets: lnstat_util.c: In function ‘lnstat_scan_fields’: lnstat_util.c:145:7: error: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Werror=unused-result] lnstat_util.c: In function ‘lnstat_update’: lnstat_util.c:97:10: error: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Werror=unused-result] lnstat_util.c:111:9: error: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Werror=unused-result] lnstat_util.c: In function ‘scan_lines’: lnstat_util.c:52:8: error: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Werror=unused-result] cc1: all warnings being treated as errors make[1]: *** [lnstat_util.o] Error 1 make[1]: Leaving directory `/home/christoph/workspace/linux/iproute2/misc' make: *** [all] Error 2 Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be> --- misc/lnstat_util.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/misc/lnstat_util.c b/misc/lnstat_util.c index 9492baf..103c05d 100644 --- a/misc/lnstat_util.c +++ b/misc/lnstat_util.c @@ -49,7 +49,8 @@ static int scan_lines(struct lnstat_file *lf, int i) num_lines++; - fgets(buf, sizeof(buf)-1, lf->fp); + if (!fgets(buf, sizeof(buf)-1, lf->fp)) + return num_lines; gettimeofday(&lf->last_read, NULL); for (j = 0; j < lf->num_fields; j++) { @@ -94,7 +95,8 @@ int lnstat_update(struct lnstat_file *lnstat_files) rewind(lf->fp); if (!lf->compat) { /* skip first line */ - fgets(buf, sizeof(buf)-1, lf->fp); + if (!fgets(buf, sizeof(buf)-1, lf->fp)) + return 0; } scan_lines(lf, 1); @@ -108,7 +110,8 @@ int lnstat_update(struct lnstat_file *lnstat_files) } rewind(lf->fp); - fgets(buf, sizeof(buf)-1, lf->fp); + if (!fgets(buf, sizeof(buf)-1, lf->fp)) + return 0; scan_lines(lf, 0); } } @@ -142,7 +145,8 @@ static int lnstat_scan_fields(struct lnstat_file *lf) char buf[FGETS_BUF_SIZE]; rewind(lf->fp); - fgets(buf, sizeof(buf)-1, lf->fp); + if (!fgets(buf, sizeof(buf)-1, lf->fp)) + return -1; return __lnstat_scan_fields(lf, buf); } -- 1.8.1.2
prev parent reply other threads:[~2013-07-20 20:06 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-20 19:58 [PATCH iproute2 0/2] Fix compiler-errors with gcc 4.7.3 Christoph Paasch 2013-07-20 19:58 ` [PATCH iproute2 1/2] ss: Fix compiler errors of unused return-values Christoph Paasch 2013-07-22 14:54 ` Stephen Hemminger 2013-07-22 15:06 ` Denis Kirjanov 2013-07-22 15:35 ` Stephen Hemminger 2013-07-22 15:14 ` Christoph Paasch 2013-07-22 15:38 ` Eric Dumazet 2013-07-22 17:26 ` Ben Hutchings 2013-07-20 19:58 ` Christoph Paasch [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1374350298-1177-3-git-send-email-christoph.paasch@uclouvain.be \ --to=christoph.paasch@uclouvain.be \ --cc=netdev@vger.kernel.org \ --cc=stephen@networkplumber.org \ --subject='Re: [PATCH iproute2 2/2] lnstat: Fix compiler errors of unused return-values' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).