netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Peter Wu <lekensteyn@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>, <netdev@vger.kernel.org>,
	"Realtek linux nic maintainers" <nic_swsd@realtek.com>
Subject: Re: [RFC] EEPROM dumping/changing code for r8169 driver
Date: Sun, 21 Jul 2013 21:12:13 +0100	[thread overview]
Message-ID: <1374437533.2804.71.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <3011523.vtKLIuqRfe@al>

On Sun, 2013-07-21 at 18:27 +0200, Peter Wu wrote:
> On Sunday 21 July 2013 17:01:54 Ben Hutchings wrote:
> > On Fri, 2013-07-19 at 11:48 +0200, Peter Wu wrote:
> > > Hi,
> > > 
> > > As noted in another mail, I have been working on adding EEPROM reading
> > > writing support for the r8169 driver. The below diff adds basic support,
> > > but it
> > > is not completely finished yet:
> > [...]
> > 
> > > --- a/drivers/net/ethernet/realtek/Kconfig
> > > +++ b/drivers/net/ethernet/realtek/Kconfig
> > > @@ -112,4 +112,13 @@ config R8169
> > > 
> > >  	  To compile this driver as a module, choose M here: the module
> > >  	  will be called r8169.  This is recommended.
> > > 
> > > +config R8169_93CX6
> > > +	bool "Realtek 8169 external 93CX6 EEPROM support"
> > > +	depends on R8169
> > > +	select EEPROM_93CX6
> > 
> > [...]
> > 
> > This select is wrong as it will cause EEPROM_93CX6=y even if R8169=m.
> > But why make this an option at all?
> For this, I got inspiration from drivers/ethernet/8390/Kconfig which had an
> AX88796_93CX6 option. Reading EEPROM is currently not a critical piece of
> functionality, so I decided to make this optional.

Most ethtool operations are not critical, but it costs very little to
implement them unconditionally (and config options increase the
maintenance burden).

> There seem also to be newer
> hardware that use a two-wired serial interface for accessing EEPROM instead of
> 93C46/93C56/93C66. Would you suggest always including this code (distro
> kernels should typically enable this) or making it optional?
[...]

Always include it.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

      reply	other threads:[~2013-07-21 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  9:48 Peter Wu
2013-07-21 16:01 ` Ben Hutchings
2013-07-21 16:27   ` Peter Wu
2013-07-21 20:12     ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374437533.2804.71.camel@deadeye.wl.decadent.org.uk \
    --to=bhutchings@solarflare.com \
    --cc=lekensteyn@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    --subject='Re: [RFC] EEPROM dumping/changing code for r8169 driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).