From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Date: Sun, 21 Jul 2013 21:50:01 +0100 Message-ID: <1374439801.2804.90.camel@deadeye.wl.decadent.org.uk> References: <20130617181004.GA1364@fedora-17-guest.dell.com> <20130711203938.GA4078@minipsycho.orion> <20130715153410.GA10864@fedora18-dev.oslab.blr.amer.dell.com> <20130721072455.GA1944@minipsycho.orion> <1374418103.16533.69.camel@deadeye.wl.decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jiri Pirko , , , To: Or Gerlitz Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:30873 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756064Ab3GUU4E (ORCPT ); Sun, 21 Jul 2013 16:56:04 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2013-07-21 at 23:29 +0300, Or Gerlitz wrote: > On Sun, Jul 21, 2013 at 5:48 PM, Ben Hutchings > wrote: > > On Sun, 2013-07-21 at 14:14 +0300, Or Gerlitz wrote: > >> On Sun, Jul 21, 2013 at 10:24 AM, Jiri Pirko wrote: > >> [...] > >> > >> Sorry, I missed that fact that initially you responded on this thread > >> > >> > The value could be anything. But note that you have to have different > >> > values for card1-port1,2 and card2-port1,2 > >> > >> why? > > > > The intent is to identify physical ports uniquely, so userland can tell > > whether two devices are backed by the same physical port. > > OK this makes sense, and I understand that there are also some SRIOV > aspects / use cases where this field could be usefu, still I don't > understamd the direct relation to virtual functions, as mentioned in > the 1st patch. Well the motivating problem was that a guest can't tell which VFs connect to which ports or whether it has multiple VFs connected to the same port. The host can already see work out that they're associated based on PCIe config and topology. This can also apply to PFs if you pass them through to guests, or if you have multiple PFs connected to the same port, but that's rather less common. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.