From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Pravin B Shelar <pshelar@nicira.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ip: initialize hash list
Date: Mon, 22 Jul 2013 08:31:09 -0700 [thread overview]
Message-ID: <1374507069.2061.48.camel@joe-AO722> (raw)
In-Reply-To: <1374506158.4990.11.camel@edumazet-glaptop>
On Mon, 2013-07-22 at 08:15 -0700, Eric Dumazet wrote:
> On Mon, 2013-07-22 at 08:06 -0700, Joe Perches wrote:
> > On Mon, 2013-07-22 at 07:52 -0700, Stephen Hemminger wrote:
> > > On Sat, 20 Jul 2013 10:46:20 -0700
> > > Joe Perches <joe@perches.com> wrote:
> > []
> > > > Are you doing to do just this one or submit a series?
> > >
> > > Hadn't planned on fixing more than one. And would not go outside code
> > > that I actually use.
> >
> > What a pity.
> >
> > I think if you identify what you believe is a
> > trivial defect in your own code, it's both
> > polite and social to fix similar defects in
> > other code too.
>
> Joe, I find this quite misplaced.
Our opinions differ then.
What's "misplaced" about suggesting that a
person that identifies and submits a patch
for a code form viewed as sub-optimal could
fix the other instances of that code form?
> So far, there is no bug.
I did not even suggest there was a bug.
I wrote "trivial defect".
> What about fixing real bugs instead ?
That'd be good too, with the caveat that
those "real bugs" can take a rather more
intensive effort to identify, isolate and
correct without introducing other defects.
next prev parent reply other threads:[~2013-07-22 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 17:26 [PATCH net-next] ip: initialize hash list Stephen Hemminger
2013-07-20 17:46 ` Joe Perches
2013-07-22 14:52 ` Stephen Hemminger
2013-07-22 15:06 ` Joe Perches
2013-07-22 15:15 ` Eric Dumazet
2013-07-22 15:31 ` Joe Perches [this message]
2013-07-20 19:20 ` David Miller
2013-07-20 20:28 ` Joe Perches
2013-07-22 15:17 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374507069.2061.48.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).