netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	<linux-net-drivers@solarflare.com>,
	"Linux Kernel Development" <linux-kernel@vger.kernel.org>,
	<linux-s390@vger.kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and reduce alignment if appropriate
Date: Tue, 23 Jul 2013 21:19:32 +0100	[thread overview]
Message-ID: <1374610772.2072.22.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <1368482482.3305.50.camel@bwh-desktop.uk.solarflarecom.com>

On Mon, 2013-05-13 at 23:01 +0100, Ben Hutchings wrote:
[...]
> This still doesn't fix the s390 build because like most architectures
> it has NET_IP_ALIGN == 2.  When NET_IP_ALIGN != 0 we cannot achieve
> cache line alignment at either the start or end of a scatter buffer,
> so there is actually no point in padding the buffers to a multiple of
> the cache line size.  All we need is 4-byte alignment of the network
> header, so do that.
[...]

I was just thinking about this again.  Do we need to care about
alignment in a page fragment at all?  Won't all the headers be pulled
into the header area before being accessed with any instructions that
would require alignment?  (We aren't using build_skb().)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

  parent reply	other threads:[~2013-07-23 20:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 21:58 [PATCHv2 net 1/2] sfc: Delete EFX_PAGE_IP_ALIGN, equivalent to NET_IP_ALIGN Ben Hutchings
2013-05-13 22:01 ` [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and reduce alignment if appropriate Ben Hutchings
2013-05-14  7:09   ` Geert Uytterhoeven
2013-05-14 18:32   ` David Miller
2013-07-23 20:19   ` Ben Hutchings [this message]
2013-05-14  8:32 ` [PATCHv2 net 1/2] sfc: Delete EFX_PAGE_IP_ALIGN, equivalent to NET_IP_ALIGN David Laight
2013-05-14 13:48   ` Ben Hutchings
2013-05-14 18:32 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374610772.2072.22.camel@bwh-desktop.uk.level5networks.com \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCHv2 net 2/2] sfc: Reduce RX scatter buffer size, and reduce alignment if appropriate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).