From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH V2 net-next 2/2] pch_gbe: Add MinnowBoard support Date: Wed, 24 Jul 2013 20:14:24 -0700 Message-ID: <1374722064.3436.252.camel@dvhart-mobl1.amr.corp.intel.com> References: <79241b53ec4e638008ba3384958ef9901ad11338.1374525261.git.dvhart@linux.intel.com> <20130724.170008.924195436945641752.davem@davemloft.net> <1374711603.3436.246.camel@dvhart-mobl1.amr.corp.intel.com> <1374712895.1924.13.camel@joe-AO722> <1374721094.3436.249.camel@dvhart-mobl1.amr.corp.intel.com> <1374721731.1924.34.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, hpa@zytor.com, peter.p.waskiewicz.jr@intel.com, andriy.shevchenko@linux.intel.com To: Joe Perches Return-path: Received: from mga14.intel.com ([143.182.124.37]:46468 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562Ab3GYDO0 (ORCPT ); Wed, 24 Jul 2013 23:14:26 -0400 In-Reply-To: <1374721731.1924.34.camel@joe-AO722> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2013-07-24 at 20:08 -0700, Joe Perches wrote: > On Wed, 2013-07-24 at 19:58 -0700, Darren Hart wrote: > > On Wed, 2013-07-24 at 17:41 -0700, Joe Perches wrote: > > > On Wed, 2013-07-24 at 17:20 -0700, Darren Hart wrote: > > > > Ah, thanks. Leftover from a more complex driver_data with pointers to > > > > these functions. I'll fix and resubmit this patch alone as V3. > > > > Otherwise, no objections? > > > > > > Only small nit is not using kernel-doc for this bit below: > [] > > I was following the existing style of the file (with the exception of > > the leading two ** as checkpatch complains. I thought erring on the side > > of consistency was the best course of action here. What would you > > suggest is the preferred approach here? > > Hi Darren. > > I hadn't actually looked at the rest of the unpatched > file. If what you did is the same style, it's fine. > > It just looked like you were trying to use kernel-doc > formatting style but not using it quite correctly. > > > > On Mon, 2013-07-22 at 14:41 -0700, Darren Hart wrote: > > > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c > > > > [] > > > > +/* pch_gbe_phy_tx_clk_delay - Setup TX clock delay via the PHY > > > > + * @hw: Pointer to the HW structure > > > > + * Returns > > > > + * 0: Successful. > > > > + * -EINVAL: Invalid argument. > > > > + */ > > This bit in what I believe kernel-doc style is would > look like: > > /** > * pch_gbe_phy_tx_clk_delay - Setup TX clock delay via the PHY > * @hw: Pointer to the HW structure > * > * Return: O: Successful > * -EINVAL: Invalid argument > */ Right, but /**\n is discouraged? outlawed? on netdev. I'm not sure what the kernel-doc policy would be for netdev... I think a follow-up patch is in order for this driver that continues to fix a variety of formatting, coding style, and api usage violations in addition to those Andy already provided. I'll resubmit with the fix David asked for to get this functionality in and consider a clean-up as a follow-on. Thanks again! -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel