From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> To: Fabio Baltieri <fabio.baltieri-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] mac80211: use oneshot blink API for LED triggers Date: Thu, 25 Jul 2013 09:58:21 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20130724085337.GA7096-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org> (sfid-20130724_105341_536708_82A83A0A) On Wed, 2013-07-24 at 10:53 +0200, Fabio Baltieri wrote: > On Wed, Jul 24, 2013 at 10:14:25AM +0200, Johannes Berg wrote: > > On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote: > > > Changes mac80211 LED trigger code to use the generic > > > led_trigger_blink_oneshot() API for transmit and receive activity > > > indication. > > > > > > This gives a better feedback to the user, as with the new API each > > > activity event results in a visible blink, while a constant traffic > > > results in a continuous blink at constant rate. > > > > This seems a little pointless since our throughput-based trigger can do > > very similar (but somewhat better) behaviour? Maybe that should just be > > the default instead, with some sane default setup values? > > Ok but that requires driver specific support and it's only implemented > on a subset of currently available drivers. Not necessarily, it's just done that way because we expected everyone to have their own idea of what the blink speeds should be, possibly even depending on the maximum speed the hardware can do etc. > This at least makes the basic tx/rx indication capability a better. Fair enough. > > (Regardless of that, you also have indentation problems in your patch) > > Ok, I guess you are referring to the this: > > + led_trigger_blink_oneshot(local->tx_led, > + &led_delay, &led_delay, 0); Yes, that was the place I noticed, didn't check more closely. > So, are you definitely rejecting this patch or should I fix indentation > and send a v2? I think I'll take it, I kinda hope nobody will really care much about it but the behaviour looks better and the code is simpler, so ... :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-07-25 7:58 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-24 0:09 Fabio Baltieri 2013-07-24 0:09 ` Fabio Baltieri 2013-07-24 8:14 ` Johannes Berg 2013-07-24 8:53 ` Fabio Baltieri [not found] ` <20130724085337.GA7096-lYxsXyORJ9v/PtFMR13I2A@public.gmane.org> 2013-07-25 7:58 ` Johannes Berg [this message] 2013-07-25 9:58 ` Fabio Baltieri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=fabio.baltieri-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --subject='Re: [PATCH] mac80211: use oneshot blink API for LED triggers' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).