* [PATCH] e100: dump small buffers via %*phC
@ 2013-07-25 11:24 Andy Shevchenko
2013-07-26 11:12 ` [E1000-devel] " Jeff Kirsher
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2013-07-25 11:24 UTC (permalink / raw)
To: netdev, Peter P Waskiewicz Jr, e1000-devel; +Cc: Andy Shevchenko
There is nice specifier in kernel that allows us to print small buffers easily.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ethernet/intel/e100.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 5115ae7..0da5911 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1175,15 +1175,12 @@ static int e100_configure(struct nic *nic, struct cb *cb, struct sk_buff *skb)
config->rx_discard_short_frames = 0x0; /* 1=discard, 0=save */
}
- netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
- "[00-07]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
- c[0], c[1], c[2], c[3], c[4], c[5], c[6], c[7]);
- netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
- "[08-15]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
- c[8], c[9], c[10], c[11], c[12], c[13], c[14], c[15]);
- netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
- "[16-23]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
- c[16], c[17], c[18], c[19], c[20], c[21], c[22], c[23]);
+ netif_printk(nic, hw, KERN_DEBUG, nic->netdev, "[00-07]=%8phC\n",
+ c + 0);
+ netif_printk(nic, hw, KERN_DEBUG, nic->netdev, "[08-15]=%8phC\n",
+ c + 8);
+ netif_printk(nic, hw, KERN_DEBUG, nic->netdev, "[16-23]=%8phC\n",
+ c + 16);
return 0;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [E1000-devel] [PATCH] e100: dump small buffers via %*phC
2013-07-25 11:24 [PATCH] e100: dump small buffers via %*phC Andy Shevchenko
@ 2013-07-26 11:12 ` Jeff Kirsher
2013-07-31 12:20 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Kirsher @ 2013-07-26 11:12 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: netdev, Peter P Waskiewicz Jr, e1000-devel
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote:
> There is nice specifier in kernel that allows us to print small
> buffers easily.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/ethernet/intel/e100.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
Thanks, I appreciate you sending this again...
I already have this patch queued up for upstream and it will be in the
next series I send.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [E1000-devel] [PATCH] e100: dump small buffers via %*phC
2013-07-26 11:12 ` [E1000-devel] " Jeff Kirsher
@ 2013-07-31 12:20 ` Andy Shevchenko
2013-07-31 12:32 ` Jeff Kirsher
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2013-07-31 12:20 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, Peter P Waskiewicz Jr, e1000-devel
On Fri, 2013-07-26 at 04:12 -0700, Jeff Kirsher wrote:
> On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote:
> > There is nice specifier in kernel that allows us to print small
> > buffers easily.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/net/ethernet/intel/e100.c | 15 ++++++---------
> > 1 file changed, 6 insertions(+), 9 deletions(-)
>
> Thanks, I appreciate you sending this again...
>
> I already have this patch queued up for upstream and it will be in the
> next series I send.
Oh, sorry for resending.
I cleared up my queue after rebasing to recent linux-next, where the
patch is not appeared yet, that's why duplicate was created.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [E1000-devel] [PATCH] e100: dump small buffers via %*phC
2013-07-31 12:20 ` Andy Shevchenko
@ 2013-07-31 12:32 ` Jeff Kirsher
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Kirsher @ 2013-07-31 12:32 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: netdev, Peter P Waskiewicz Jr, e1000-devel
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Wed, 2013-07-31 at 15:20 +0300, Andy Shevchenko wrote:
> On Fri, 2013-07-26 at 04:12 -0700, Jeff Kirsher wrote:
> > On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote:
> > > There is nice specifier in kernel that allows us to print small
> > > buffers easily.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/net/ethernet/intel/e100.c | 15 ++++++---------
> > > 1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > Thanks, I appreciate you sending this again...
> >
> > I already have this patch queued up for upstream and it will be in
> the
> > next series I send.
>
> Oh, sorry for resending.
> I cleared up my queue after rebasing to recent linux-next, where the
> patch is not appeared yet, that's why duplicate was created.
No problem, sorry for the delay in getting it upstream and feel free to
ping me next time.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-31 12:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-25 11:24 [PATCH] e100: dump small buffers via %*phC Andy Shevchenko
2013-07-26 11:12 ` [E1000-devel] " Jeff Kirsher
2013-07-31 12:20 ` Andy Shevchenko
2013-07-31 12:32 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).