From: Ben Hutchings <bhutchings@solarflare.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: "Eric Dumazet" <eric.dumazet@gmail.com>,
"Oliver Neukum" <oliver@neukum.org>,
"Grant Grundler" <grundler@google.com>,
"Freddy Xin" <freddy@asix.com.tw>,
"David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"ASIX Louis [蘇威陸]" <louis@asix.com.tw>,
"Allan Chou" <allan@asix.com.tw>
Subject: Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A
Date: Thu, 25 Jul 2013 16:00:35 +0100 [thread overview]
Message-ID: <1374764435.3058.4.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <CACVXFVNre5SsJhaVqFNRcop7ahqxabWqHZkjBZccj1ZqOAUZ9A@mail.gmail.com>
On Thu, 2013-07-25 at 22:52 +0800, Ming Lei wrote:
[...]
> On Thu, Jul 25, 2013 at 9:34 PM, Ben Hutchings
> <bhutchings@solarflare.com> wrote:
> >
> > Not that I have any experience with USB drivers, but perhaps
> > usb_sg_init()?
>
> USB SG library doesn't support submitting SG URB asynchronously, but that isn't
> a big deal. The problem is that many USB host controllers can't build
> one single
> packet from two buffers, what is why USB stack requires size of all
> buffers(except
> for last one) in sg list can be divided by max endpoint packet
> size.(1024 for usbnet)
Ugh. Maybe the USB stack should allow drivers to find out about and
take advantage of a more flexible host controller. Sounds like it could
be a big job, though.
Ben. (glad not to be using any USB net devices)
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-07-25 15:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 9:16 [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A freddy
2013-07-22 17:07 ` Eric Dumazet
2013-07-22 17:11 ` Ben Hutchings
2013-07-22 18:29 ` Grant Grundler
2013-07-22 18:38 ` Ben Hutchings
2013-07-22 18:47 ` Eric Dumazet
2013-07-22 19:47 ` Ben Hutchings
[not found] ` <1374522471.1635.48.camel-/LGg1Z1CJKQ+9kgCwbf1HqK4ta4zdZpAajtMo4Cw6ucAvxtiuMwx3w@public.gmane.org>
2013-07-23 6:10 ` Eric Dumazet
2013-07-23 23:46 ` David Miller
2013-07-23 23:56 ` Eric Dumazet
2013-07-24 0:05 ` Eric Dumazet
2013-07-24 0:15 ` [PATCH] usbnet: do not pretend to support SG/TSO Eric Dumazet
2013-07-26 20:48 ` David Miller
2013-07-24 0:17 ` [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A David Miller
2013-07-24 2:29 ` Grant Grundler
[not found] ` <CANEJEGtLavwdPdq_Qojz_x-DQ3KXfZp0vPYr6imKtNxN0Hf_2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-24 2:32 ` Grant Grundler
2013-07-25 2:28 ` Ming Lei
2013-07-25 5:10 ` Eric Dumazet
2013-07-25 5:25 ` Ming Lei
[not found] ` <CACVXFVNyFk0Zpi4tC0ENiq8RcrtrjYW-Dhs+A56+Pw4BKm8y8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-25 11:01 ` Eric Dumazet
2013-07-25 14:52 ` Ming Lei
2013-07-25 15:00 ` Ben Hutchings [this message]
[not found] ` <CACVXFVNre5SsJhaVqFNRcop7ahqxabWqHZkjBZccj1ZqOAUZ9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-25 15:11 ` Eric Dumazet
2013-07-25 13:34 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374764435.3058.4.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=allan@asix.com.tw \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=freddy@asix.com.tw \
--cc=grundler@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=louis@asix.com.tw \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).