From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN Date: Mon, 29 Jul 2013 12:34:24 -0700 Message-ID: <1375126464.2075.46.camel@joe-AO722> References: <2929374.frUlkyTFNL@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Len Brown , Pantelis Antoniou , Vitaly Bordug , Steve Glendinning , Mauro Carvalho Chehab , Samuel Ortiz , "David S. Miller" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org To: "Rafael J. Wysocki" Return-path: In-Reply-To: <2929374.frUlkyTFNL@vostro.rjw.lan> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote: > On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote: > > It's convenient to have ethernet mac addresses use > > ETH_ALEN to be able to grep for them a bit easier and > > also to ensure that the addresses are __aligned(2). [] > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h [] > > @@ -44,6 +44,8 @@ [] > > +#include > > + [] > > @@ -605,7 +607,7 @@ struct acpi_ibft_nic { [] > > - u8 mac_address[6]; > > + u8 mac_address[ETH_ALEN]; > Please don't touch this file. > > It comes from a code base outside of the kernel and should be kept in sync with > the upstream. Which files in include/acpi have this characteristic? Perhaps an include/acpi/README is appropriate.