From: Paul Bolle <pebolle@tiscali.nl>
To: David Miller <davem@davemloft.net>
Cc: linus.luessing@web.de, bridge@lists.linux-foundation.org,
stephen@networkplumber.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au,
amwang@redhat.com, linux@baker-net.org.uk
Subject: Re: [PATCHv3] bridge: disable snooping if there is no querier
Date: Mon, 05 Aug 2013 10:41:06 +0200 [thread overview]
Message-ID: <1375692066.25148.14.camel@x61.thuisdomein> (raw)
In-Reply-To: <20130731.174037.1794753574143053874.davem@davemloft.net>
On Wed, 2013-07-31 at 17:40 -0700, David Miller wrote:
> > If there is no querier on a link then we won't get periodic reports and
> > therefore won't be able to learn about multicast listeners behind ports,
> > potentially leading to lost multicast packets, especially for multicast
> > listeners that joined before the creation of the bridge.
> >
> > These lost multicast packets can appear since c5c23260594
> > ("bridge: Add multicast_querier toggle and disable queries by default")
> > in particular.
> >
> > With this patch we are flooding multicast packets if our querier is
> > disabled and if we didn't detect any other querier.
> >
> > A grace period of the Maximum Response Delay of the querier is added to
> > give multicast responses enough time to arrive and to be learned from
> > before disabling the flooding behaviour again.
> >
> > Signed-off-by: Linus Lüssing <linus.luessing@web.de>
>
> Looks good, applied, thanks Linus.
0) This patch is part of v3.11-rc4 as commit b00589af3b0. It introduced
a GCC warning:
net/bridge/br_multicast.c: In function ‘br_multicast_rcv’:
net/bridge/br_multicast.c:1081:36: warning: ‘max_delay’ may be used uninitialized in this function [-Wmaybe-uninitialized]
net/bridge/br_multicast.c:1178:16: note: ‘max_delay’ was declared here
1) Summarized, the code reads:
unsigned long max_delay;
if (skb->len == sizeof(*mld))
max_delay = msecs_to_jiffies(ntohs(mld->mld_maxdelay));
else if (skb->len >= sizeof(*mld2q))
max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1;
br_multicast_query_received(br, port, !ipv6_addr_any(&ip6h->saddr),
max_delay);
So GCC notices that max_delay is still uninitialized if skb->len is
neither equal to sizeof(*mld) nor equal or bigger than sizeof(*mld2q).
To me it looks GCC is right here. At least, it is not obvious that
max_delay will actually not be used in br_multicast_query_received() if
it still is uninitialized.
2) I'm entirely unfamiliar to this code. So I can't say how this warning
might be silenced.
Paul Bolle
next prev parent reply other threads:[~2013-08-05 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 12:57 [PATCH] bridge: disable snooping if there is no querier Linus Lüssing
2013-07-25 13:56 ` [PATCHv2] " Linus Lüssing
2013-07-25 16:01 ` Stephen Hemminger
2013-07-25 19:31 ` Linus Lüssing
2013-07-26 22:19 ` Adam Baker
2013-07-27 15:54 ` Linus Lüssing
2013-07-30 23:10 ` David Miller
2013-07-31 23:06 ` [PATCHv3] " Linus Lüssing
2013-08-01 0:40 ` David Miller
2013-08-05 8:41 ` Paul Bolle [this message]
2013-08-05 22:40 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375692066.25148.14.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linus.luessing@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@baker-net.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).