From: Oliver Neukum <oneukum@suse.de>
To: Ming Lei <ming.lei@canonical.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Grant Grundler <grundler@google.com>,
Freddy Xin <freddy@asix.com.tw>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v2 3/4] USBNET: support DMA SG
Date: Mon, 05 Aug 2013 11:14:28 +0200 [thread overview]
Message-ID: <1375694068.4676.1.camel@linux-fkkt.site> (raw)
In-Reply-To: <1375692423-9497-4-git-send-email-ming.lei@canonical.com>
On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote:
> @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
> entry = (struct skb_data *) skb->cb;
> entry->urb = urb;
> entry->dev = dev;
> - entry->length = length;
>
> usb_fill_bulk_urb (urb, dev->udev, dev->out,
> skb->data, skb->len, tx_complete, skb);
> + if (dev->can_dma_sg) {
> + if (build_dma_sg(skb, urb) < 0)
> + goto drop;
This is still missing a kfree() for urb->sg in the error case
of usbnet_start_xmit().
Regards
Oliver
next prev parent reply other threads:[~2013-08-05 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 8:46 [PATCH v2 0/4] USB & USBNET: loose SG check and support usbnet DMA SG Ming Lei
2013-08-05 8:47 ` [PATCH v2 1/4] USB: introduce usb_device_no_sg_constraint() helper Ming Lei
[not found] ` <1375692423-9497-2-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-08-05 14:07 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1308051005150.1239-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-08-05 14:33 ` Ming Lei
[not found] ` <1375692423-9497-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2013-08-05 8:47 ` [PATCH v2 2/4] USB: XHCI: mark no_sg_constraint Ming Lei
2013-08-05 8:47 ` [PATCH v2 3/4] USBNET: support DMA SG Ming Lei
2013-08-05 9:14 ` Oliver Neukum [this message]
2013-08-05 9:23 ` Ming Lei
2013-08-05 8:47 ` [PATCH v2 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375694068.4676.1.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=freddy@asix.com.tw \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).