From: Ben Hutchings <bhutchings@solarflare.com>
To: Peter Wu <lekensteyn@gmail.com>
Cc: <netdev@vger.kernel.org>, Francois Romieu <romieu@fr.zoreil.com>
Subject: Re: [PATCH v3 1/2] realtek: convert to per-chip mask
Date: Fri, 9 Aug 2013 11:44:50 +0200 [thread overview]
Message-ID: <1376041490.14810.5.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <6171378.LP1RDUmkgD@al>
On Fri, 2013-08-09 at 10:51 +0200, Peter Wu wrote:
> On Thursday 08 August 2013 20:25:41 Ben Hutchings wrote:
> > On Thu, 2013-07-25 at 15:36 +0200, Peter Wu wrote:
> > [...]
> >
> > > @@ -35,36 +32,62 @@ enum chip_type {
> > >
> > > RTL8100E2,
> > >
> > > };
> > >
> > > -enum {
> > > - chip_type_mask = HW_REVID(1, 1, 1, 1, 1, 1, 1, 1)
> > > +static const char * const chip_names[] = {
> > > + [RTL8139] = "8139",
> > > + [RTL8139_K] = "8139-K",
> > > + [RTL8139A] = "8139A",
> > > + [RTL8139A_G] = "8139A-G",
> > > + [RTL8139B] = "8139B",
> > > + [RTL8130] = "8130",
> > > + [RTL8139C] = "8139C",
> > > + [RTL8100] = "8100",
> > > + [RTL8100B_8139D] = "8100B/8139D",
> > > + [RTL8139C] = "8139C+",
> >
> > Shouldn't the index here be RTL8139Cp?
>
> The specifications mention "RTL8139C+", I took pre-8169 names from the previous
> rtl_info_tbl contents:
[...]
I'm talking about the index, not the name. This has an index of
RTL8139C which is also used 3 lines up.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-08-09 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:36 [PATCH v3 0/2] [ethtool] Add new Realtek devices Peter Wu
2013-07-25 13:36 ` [PATCH v3 1/2] realtek: convert to per-chip mask Peter Wu
2013-08-08 18:25 ` Ben Hutchings
2013-08-09 8:51 ` Peter Wu
2013-08-09 9:44 ` Ben Hutchings [this message]
2013-08-09 9:58 ` Peter Wu
2013-07-25 13:36 ` [PATCH v3 2/2] realtek: update devices to 3.11 Peter Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376041490.14810.5.camel@deadeye.wl.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=lekensteyn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).