From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Linus=20L=C3=BCssing?= Subject: [PATCH net-next 2/2] bridge: apply multicast snooping to IPv6 link-local, too Date: Wed, 4 Sep 2013 02:13:39 +0200 Message-ID: <1378253619-23918-3-git-send-email-linus.luessing@web.de> References: <1378253619-23918-1-git-send-email-linus.luessing@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: bridge@lists.linux-foundation.org, Stephen Hemminger , "David S. Miller" , linux-kernel@vger.kernel.org, Herbert Xu , Cong Wang , Adam Baker , =?UTF-8?q?Linus=20L=C3=BCssing?= To: netdev@vger.kernel.org Return-path: Received: from mout.web.de ([212.227.15.3]:63327 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761445Ab3IDAOY (ORCPT ); Tue, 3 Sep 2013 20:14:24 -0400 Received: from localhost ([141.83.153.180]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0MaJng-1VajRb2CD2-00JrUs for ; Wed, 04 Sep 2013 02:14:22 +0200 In-Reply-To: <1378253619-23918-1-git-send-email-linus.luessing@web.de> Sender: netdev-owner@vger.kernel.org List-ID: The multicast snooping code should have matured enough to be safely applicable to IPv6 link-local multicast addresses (excluding the link-local all nodes address, ff02::1), too. Signed-off-by: Linus L=C3=BCssing --- net/bridge/br_mdb.c | 3 ++- net/bridge/br_multicast.c | 7 ++++--- net/bridge/br_private.h | 10 ---------- 3 files changed, 6 insertions(+), 14 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index a7c6cd0..85a09bb 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -9,6 +9,7 @@ #include #if IS_ENABLED(CONFIG_IPV6) #include +#include #endif =20 #include "br_private.h" @@ -254,7 +255,7 @@ static bool is_valid_mdb_entry(struct br_mdb_entry = *entry) return false; #if IS_ENABLED(CONFIG_IPV6) } else if (entry->addr.proto =3D=3D htons(ETH_P_IPV6)) { - if (!ipv6_is_transient_multicast(&entry->addr.u.ip6)) + if (ipv6_addr_is_ll_all_nodes(&entry->addr.u.ip6)) return false; #endif } else diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 662ba7b..3b0ed99 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -29,6 +29,7 @@ #include #include #include +#include #endif =20 #include "br_private.h" @@ -724,7 +725,7 @@ static int br_ip6_multicast_add_group(struct net_br= idge *br, { struct br_ip br_group; =20 - if (!ipv6_is_transient_multicast(group)) + if (ipv6_addr_is_ll_all_nodes(group)) return 0; =20 br_group.u.ip6 =3D *group; @@ -1410,7 +1411,7 @@ static void br_ip6_multicast_leave_group(struct n= et_bridge *br, &br->ip6_query; =20 =20 - if (!ipv6_is_transient_multicast(group)) + if (ipv6_addr_is_ll_all_nodes(group)) return; =20 br_group.u.ip6 =3D *group; @@ -1551,7 +1552,7 @@ static int br_multicast_ipv6_rcv(struct net_bridg= e *br, return 0; =20 /* Prevent flooding this packet if there is no listener present */ - if (ipv6_is_transient_multicast(&ip6h->daddr)) + if (!ipv6_addr_is_ll_all_nodes(&ip6h->daddr)) BR_INPUT_SKB_CB(skb)->mrouters_only =3D 1; =20 if (ip6h->nexthdr !=3D IPPROTO_HOPOPTS || diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index f225fb6..598cb0b 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -494,16 +494,6 @@ extern void br_mdb_notify(struct net_device *dev, = struct net_bridge_port *port, #define mlock_dereference(X, br) \ rcu_dereference_protected(X, lockdep_is_held(&br->multicast_lock)) =20 -#if IS_ENABLED(CONFIG_IPV6) -#include -static inline int ipv6_is_transient_multicast(const struct in6_addr *a= ddr) -{ - if (ipv6_addr_is_multicast(addr) && IPV6_ADDR_MC_FLAG_TRANSIENT(addr)= ) - return 1; - return 0; -} -#endif - static inline bool br_multicast_is_router(struct net_bridge *br) { return br->multicast_router =3D=3D 2 || --=20 1.7.10.4