From: "Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>
To: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Alexey Orishko"
<alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>
Subject: [PATCH net-next 19/24] net: cdc_ncm: endian convert constants instead of variables
Date: Fri, 1 Nov 2013 11:16:56 +0100 [thread overview]
Message-ID: <1383301021-16613-20-git-send-email-bjorn@mork.no> (raw)
In-Reply-To: <1383301021-16613-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
Converting the constants used in these comparisons at build
time instead of converting the variables for every received
frame at run time.
Cc: Alexey Orishko <alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
---
drivers/net/usb/cdc_ncm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index d49e4c5..83e6d5b 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -882,7 +882,7 @@ int cdc_ncm_rx_verify_nth16(struct cdc_ncm_ctx *ctx, struct sk_buff *skb_in)
nth16 = (struct usb_cdc_ncm_nth16 *)skb_in->data;
- if (le32_to_cpu(nth16->dwSignature) != USB_CDC_NCM_NTH16_SIGN) {
+ if (nth16->dwSignature != cpu_to_le32(USB_CDC_NCM_NTH16_SIGN)) {
netif_dbg(dev, rx_err, dev->net,
"invalid NTH16 signature <%#010x>\n",
le32_to_cpu(nth16->dwSignature));
@@ -972,7 +972,7 @@ next_ndp:
ndp16 = (struct usb_cdc_ncm_ndp16 *)(skb_in->data + ndpoffset);
- if (le32_to_cpu(ndp16->dwSignature) != USB_CDC_NCM_NDP16_NOCRC_SIGN) {
+ if (ndp16->dwSignature != cpu_to_le32(USB_CDC_NCM_NDP16_NOCRC_SIGN)) {
netif_dbg(dev, rx_err, dev->net,
"invalid DPT16 signature <%#010x>\n",
le32_to_cpu(ndp16->dwSignature));
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-01 10:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 10:16 [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 01/24] net: cdc_ncm: simplify and optimize frame padding Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 02/24] net: cdc_ncm: add include protection to cdc_ncm.h Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 03/24] net: cdc_ncm: remove redundant "intf" field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 04/24] net: cdc_ncm: remove redundant endpoint pointers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 07/24] net: cdc_ncm: remove tx_speed and rx_speed fields Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 08/24] net: cdc_ncm: remove ncm_parm field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 09/24] net: cdc_ncm: fix SET_MAX_DATAGRAM_SIZE Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 10/24] net: cdc_ncm: remove descriptor pointers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 11/24] net: cdc_ncm: only the control intf can be probed Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 12/24] net: cdc_ncm: no point in filling up the NTBs if we send ZLPs Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 13/24] net: cdc_ncm: remove probe and disconnect wrappers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 15/24] net: cdc_ncm: set correct dev->hard_mtu Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_* Bjørn Mork
2013-11-01 10:36 ` Joe Perches
2013-11-04 8:59 ` Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 21/24] net: cdc_ncm: refactoring cdc_ncm_setup Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 22/24] net: cdc_ncm: return proper error if setup fails Bjørn Mork
[not found] ` <1383301021-16613-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-11-01 10:16 ` [PATCH net-next 05/24] net: cdc_ncm: remove redundant netdev field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 06/24] net: cdc_ncm: remove unused udev field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 14/24] net: cdc_ncm: remove ethtool ops Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 16/24] net: cdc_ncm: log the length we warn about Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 18/24] net: cdc_ncm: log signatures in hex Bjørn Mork
2013-11-01 10:16 ` Bjørn Mork [this message]
2013-11-01 10:16 ` [PATCH net-next 20/24] net: cdc_ncm: drop "extern" from header declarations Bjørn Mork
2013-11-01 10:17 ` [PATCH net-next 23/24] net: cdc_ncm: improve bind error debug messages Bjørn Mork
2013-11-01 10:17 ` [PATCH net-next 24/24] net: cdc_ncm: no not set tx_max higher than the device supports Bjørn Mork
2013-11-02 6:02 ` [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383301021-16613-20-git-send-email-bjorn@mork.no \
--to=bjorn-yokvzcmfvru@public.gmane.org \
--cc=alexey.orishko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).