From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 09/15] i40e: properly add VF MAC addresses
Date: Fri, 6 Dec 2013 00:06:22 -0800 [thread overview]
Message-ID: <1386317188-13944-10-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1386317188-13944-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Mitch Williams <mitch.a.williams@intel.com>
The code that added new MAC addresses from the VFs did not, in
fact, work. Due to inverse logic, the only addresses that could
be added were addresses that already had been added.
Change-Id: Idce9169bd2f36e2c5ee10b130587a65705465d31
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index d98cc9b..5997301 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -1603,7 +1603,7 @@ static int i40e_vc_add_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)
struct i40e_mac_filter *f;
f = i40e_find_mac(vsi, al->list[i].addr, true, false);
- if (f) {
+ if (!f) {
if (i40e_is_vsi_in_vlan(vsi))
f = i40e_put_mac_in_vlan(vsi, al->list[i].addr,
true, false);
--
1.8.3.1
next prev parent reply other threads:[~2013-12-06 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 8:06 [net-next 00/15][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-12-06 8:06 ` [net-next 01/15] i40e: set pf_id based on device and function numbers Jeff Kirsher
2013-12-06 8:06 ` [net-next 02/15] i40e: register file updates Jeff Kirsher
2013-12-06 8:06 ` [net-next 03/15] i40e: clear AQ head and tail registers Jeff Kirsher
2013-12-06 8:06 ` [net-next 04/15] i40e: simplify aq head-tail-len setups Jeff Kirsher
2013-12-06 8:06 ` [net-next 05/15] i40e: firmware version fields offsets update Jeff Kirsher
2013-12-06 8:06 ` [net-next 06/15] i40e: allow one more vector for VFs Jeff Kirsher
2013-12-06 8:06 ` [net-next 07/15] i40e: select reset counters correctly Jeff Kirsher
2013-12-06 8:06 ` [net-next 08/15] i40e: retry call on timeout Jeff Kirsher
2013-12-06 8:06 ` Jeff Kirsher [this message]
2013-12-06 8:06 ` [net-next 10/15] i40e: fix debugging messages Jeff Kirsher
2013-12-06 8:06 ` [net-next 11/15] i40e: default debug mask setting Jeff Kirsher
2013-12-06 8:06 ` [net-next 12/15] i40e: add interrupt test Jeff Kirsher
2013-12-06 8:06 ` [net-next 13/15] i40e: add support for triggering EMPR Jeff Kirsher
2013-12-06 8:06 ` [net-next 14/15] i40e: restrict diag test length Jeff Kirsher
2013-12-06 8:06 ` [net-next 15/15] i40e: sync header files with hardware Jeff Kirsher
2013-12-06 19:49 ` [net-next 00/15][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386317188-13944-10-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).