From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: vxlan: do not use vxlan_net before checking event type Date: Sat, 18 Jan 2014 09:18:31 -0800 Message-ID: <1390065511.31367.535.camel@edumazet-glaptop2.roam.corp.google.com> References: <1389959706-30976-1-git-send-email-dborkman@redhat.com> <52D97746.1040408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Daniel Borkmann , David Miller , Linux Kernel Network Developers , "Eric W. Biederman" , Jesse Brandeburg To: Cong Wang Return-path: Received: from mail-pa0-f51.google.com ([209.85.220.51]:34545 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbaARRSd (ORCPT ); Sat, 18 Jan 2014 12:18:33 -0500 Received: by mail-pa0-f51.google.com with SMTP id ld10so3061551pab.38 for ; Sat, 18 Jan 2014 09:18:32 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2014-01-17 at 19:50 -0800, Cong Wang wrote: > On Fri, Jan 17, 2014 at 10:32 AM, Daniel Borkmann wrote: > > > > > > If you want to do cleanups, whatever, I really don't care. > > You had your chance to complain about that when you reviewed > > the initial version ... it has nothing to do with the fix. > > This is not for stable, as long as it doesn't harm the readability > we are free to do any cleanup's. > > If unsure, check Eric's patch for tunnel dst cache. > > BTW, I am the original author of the patch, you just updated > it *trivially* and set yourself as the author. :) I don't mind, but > remember that this may be not appropriate for others. At > very least I didn't and don't do this myself. Hmm... Daniel mentioned in the changelog you wrote the initial patch, and you are credited as the author of the patch, since he kept your "Signed-off-by: ..." as the first one. Quite frankly, keeping vxlan_handle_lowerdev_unregister() was the right choice. Stop thinking that a function needs to be used more than once to have the right to exist. Splitting code in small parts ease readability and code reuse/refactor, this should be obvious to you.