From: Eelco Chaudron <echaudro@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org,
pabeni@redhat.com, pshelar@ovn.org, jlelli@redhat.com,
bigeasy@linutronix.de, i maximets <i.maximets@ovn.org>
Subject: Re: [PATCH net v3] net: openvswitch: fix to make sure flow_lookup() is not preempted
Date: Sat, 17 Oct 2020 14:27:37 -0400 (EDT) [thread overview]
Message-ID: <1391537937.15081272.1602959257178.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20201016164607.4244ca24@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
----- Original Message -----
> From: "Jakub Kicinski" <kuba@kernel.org>
> To: "Eelco Chaudron" <echaudro@redhat.com>
> Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org, pabeni@redhat.com, pshelar@ovn.org,
> jlelli@redhat.com, bigeasy@linutronix.de, "i maximets" <i.maximets@ovn.org>
> Sent: Saturday, October 17, 2020 1:46:07 AM
> Subject: Re: [PATCH net v3] net: openvswitch: fix to make sure flow_lookup() is not preempted
>
> On Thu, 15 Oct 2020 19:09:33 +0200 Eelco Chaudron wrote:
> > The flow_lookup() function uses per CPU variables, which must be called
> > with BH disabled. However, this is fine in the general NAPI use case
> > where the local BH is disabled. But, it's also called from the netlink
> > context. The below patch makes sure that even in the netlink path, the
> > BH is disabled.
> >
> > In addition, u64_stats_update_begin() requires a lock to ensure one writer
> > which is not ensured here. Making it per-CPU and disabling NAPI (softirq)
> > ensures that there is always only one writer.
> >
> > Fixes: eac87c413bf9 ("net: openvswitch: reorder masks array based on
> > usage")
> > Reported-by: Juri Lelli <jlelli@redhat.com>
> > Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>
> Hi Eelco, looks like this doesn't apply after the 5.10 merges.
>
> Please respin on top of the current net.
Done, just sent out a v4.
//Eelco
prev parent reply other threads:[~2020-10-17 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 17:09 [PATCH net v3] net: openvswitch: fix to make sure flow_lookup() is not preempted Eelco Chaudron
2020-10-16 23:46 ` Jakub Kicinski
2020-10-17 18:27 ` Eelco Chaudron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391537937.15081272.1602959257178.JavaMail.zimbra@redhat.com \
--to=echaudro@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=i.maximets@ovn.org \
--cc=jlelli@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).