From: Eric Dumazet <eric.dumazet@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>,
edumazet@google.com, ast@kernel.org, daniel@iogearbox.net
Cc: netdev@vger.kernel.org
Subject: Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added
Date: Fri, 1 Jun 2018 15:58:52 -0400 [thread overview]
Message-ID: <13d3be75-4ed2-aeca-caba-797766e9b676@gmail.com> (raw)
In-Reply-To: <20180601194641.5717.11725.stgit@john-Precision-Tower-5810>
On 06/01/2018 03:46 PM, John Fastabend wrote:
> This fixes a crash where we assign tcp_prot to IPv6 sockets instead
> of tcpv6_prot.
...
> + /* ULPs are currently supported only for TCP sockets in ESTABLISHED
> + * state. Supporting sockets in LISTEN state will require us to
> + * modify the accept implementation to clone rather then share the
> + * ulp context.
> + */
> + if (sock->sk_state != TCP_ESTABLISHED)
> + return -ENOTSUPP;
> +
> /* 1. If sock map has BPF programs those will be inherited by the
> * sock being added. If the sock is already attached to BPF programs
> * this results in an error.
>
Next question will be then : What happens if syzbot uses tcp_disconnect() and then listen() ?
Thanks !
next prev parent reply other threads:[~2018-06-01 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 19:46 [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added John Fastabend
2018-06-01 19:58 ` Eric Dumazet [this message]
2018-06-02 21:39 ` John Fastabend
2018-06-04 13:39 ` Daniel Borkmann
2018-06-04 13:57 ` John Fastabend
2018-06-04 14:55 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13d3be75-4ed2-aeca-caba-797766e9b676@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).