From: Eric Dumazet <eric.dumazet@gmail.com>
To: "fugang.duan@freescale.com" <fugang.duan@freescale.com>
Cc: "ezequiel.garcia@free-electrons.com"
<ezequiel.garcia@free-electrons.com>,
David Laight <David.Laight@ACULAB.COM>,
"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: RE: [PATCH v1 4/6] net: fec: Increase buffer descriptor entry number
Date: Fri, 30 May 2014 08:40:57 -0700 [thread overview]
Message-ID: <1401464457.3645.109.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <417d6b6ae192430f9fee0a339074d9c6@BLUPR03MB373.namprd03.prod.outlook.com>
On Fri, 2014-05-30 at 15:08 +0000, fugang.duan@freescale.com wrote:
> If frag page data is not match the alignment for ethernet DMA controller, there need three descriptor for one MSS:
> One descriptor for headers, one for the first non-align bytes copied from frag page, one for the rest of frag page.
>
You could avoid the 2nd descriptor, by copying the unaligned part of the
payload into first descriptor (containing headers : about 66 bytes or so
you have room, if not, increase the 128 bytes room to 192 bytes)
> So one frame may cost descriptor number is: 3 x 45
May... but in general it would be closer of 2 * 45
>
> So the descriptors slots set to 512 is not big, just is reasonable. Do you think ?
I believe it is fine : that is about 5 64KB TSO packets.
next prev parent reply other threads:[~2014-05-30 15:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 2:05 [PATCH v1 0/6] *** net: fec: Enable Software TSO to improve the tx performance *** Fugang Duan
2014-05-30 2:05 ` [PATCH v1 1/6] net: fec: Factorize the .xmit transmit function Fugang Duan
2014-05-30 2:05 ` [PATCH v1 2/6] net: fec: Enable IP header hardware checksum Fugang Duan
2014-05-30 2:05 ` [PATCH v1 3/6] net: fec: Factorize feature setting Fugang Duan
2014-05-30 2:05 ` [PATCH v1 4/6] net: fec: Increase buffer descriptor entry number Fugang Duan
2014-05-30 9:10 ` David Laight
2014-05-30 9:42 ` fugang.duan
2014-05-30 13:13 ` Eric Dumazet
2014-05-30 14:01 ` ezequiel.garcia
2014-05-30 14:54 ` Eric Dumazet
2014-05-30 15:08 ` fugang.duan
2014-05-30 15:34 ` David Laight
2014-05-30 15:52 ` fugang.duan
2014-05-30 15:58 ` Eric Dumazet
2014-05-30 16:35 ` ezequiel.garcia
2014-05-30 15:40 ` Eric Dumazet [this message]
2014-05-30 15:46 ` fugang.duan
2014-05-30 2:05 ` [PATCH v1 5/6] net: fec: Add Scatter/gather support Fugang Duan
2014-05-30 4:37 ` Eric Dumazet
2014-05-30 4:48 ` fugang.duan
2014-05-30 14:26 ` Frank.Li
2014-05-30 2:05 ` [PATCH v1 6/6] net: fec: Add software TSO support Fugang Duan
2014-05-30 6:30 ` Eric Dumazet
2014-05-30 7:16 ` fugang.duan
2014-05-30 16:21 ` Eric Dumazet
2014-06-01 0:55 ` fugang.duan
2014-06-01 1:39 ` Eric Dumazet
2014-06-01 2:25 ` fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401464457.3645.109.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=Frank.Li@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=ezequiel.garcia@free-electrons.com \
--cc=fugang.duan@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).