From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [Patch net 3/3] ipv4: clean up cookie_v4_check() Date: Wed, 15 Oct 2014 21:17:19 -0700 Message-ID: <1413433039.28798.10.camel@edumazet-glaptop2.roam.corp.google.com> References: <1413408802-21052-1-git-send-email-xiyou.wangcong@gmail.com> <1413408802-21052-3-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, Krzysztof Kolasa , Eric Dumazet , Cong Wang To: Cong Wang Return-path: Received: from mail-pd0-f180.google.com ([209.85.192.180]:61762 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbaJPERU (ORCPT ); Thu, 16 Oct 2014 00:17:20 -0400 Received: by mail-pd0-f180.google.com with SMTP id fp1so2482594pdb.39 for ; Wed, 15 Oct 2014 21:17:20 -0700 (PDT) In-Reply-To: <1413408802-21052-3-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2014-10-15 at 14:33 -0700, Cong Wang wrote: > From: Cong Wang > > We can retrieve opt from skb, no need to pass it as a parameter. > And opt should always be non-NULL, no need to check. > > Cc: Krzysztof Kolasa > Cc: Eric Dumazet > Tested-by: Krzysztof Kolasa > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang > --- Acked-by: Eric Dumazet