From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: introduce tcp_v6_iif()
Date: Sat, 18 Oct 2014 08:30:07 -0700 [thread overview]
Message-ID: <1413646207.27176.28.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20141017.234817.1456444039400155118.davem@davemloft.net>
On Fri, 2014-10-17 at 23:48 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 17 Oct 2014 09:17:20 -0700
>
> > From: Eric Dumazet <edumazet@google.com>
> >
> > Commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line
> > misses") added a regression for SO_BINDTODEVICE on IPv6.
> >
> > This is because we still use inet6_iif() which expects that IP6 control
> > block is still at the beginning of skb->cb[]
> >
> > This patch adds tcp_v6_iif() helper and uses it where necessary.
> >
> > Because __inet6_lookup_skb() is used by TCP and DCCP, we add an iif
> > parameter to it.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > Fixes: 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses")
>
> Applied.
Oh well, I forgot IPV6 could be not present in .config
Will send a patch, sorry for this.
$ make M=net/ipv4
CC net/ipv4/route.o
In file included from net/ipv4/route.c:102:0:
include/net/tcp.h: In function ‘tcp_v6_iif’:
include/net/tcp.h:738:32: error: ‘union <anonymous>’ has no member named ‘h6’
return TCP_SKB_CB(skb)->header.h6.iif;
prev parent reply other threads:[~2014-10-18 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 16:17 [PATCH net] ipv6: introduce tcp_v6_iif() Eric Dumazet
2014-10-17 16:26 ` David Laight
2014-10-17 16:52 ` Eric Dumazet
2014-10-17 16:58 ` Cong Wang
2014-10-17 18:19 ` Eric Dumazet
2014-10-18 0:00 ` Cong Wang
2014-10-18 0:02 ` Cong Wang
2014-10-18 3:48 ` David Miller
2014-10-18 15:30 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413646207.27176.28.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).