From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Cc: edumazet@google.com, therbert@google.com
Subject: [PATCH v2 0/3] net: minor gso encapsulation fixes
Date: Mon, 20 Oct 2014 13:49:15 +0200 [thread overview]
Message-ID: <1413805758-30026-1-git-send-email-fw@strlen.de> (raw)
The following series fixes a minor bug in the gso segmentation handlers
when encapsulation offload is used.
Theoretically this could cause kernel panic when the stack tries
to software-segment such a GRE offload packet, but it looks like there
is only one affected call site (tbf scheduler) and it handles NULL
return value.
I've included a followup patch to add IS_ERR_OR_NULL checks where needed.
While looking into this, I also found that size computation of the individual
segments is incorrect if skb->encapsulation is set.
Please see individual patches for delta vs. v1.
core/skbuff.c | 13 ++++++++++---
ipv4/af_inet.c | 2 +-
ipv4/gre_offload.c | 2 +-
ipv4/ip_output.c | 2 +-
ipv4/udp_offload.c | 2 +-
ipv6/ip6_offload.c | 2 +-
mpls/mpls_gso.c | 2 +-
netfilter/nfnetlink_queue_core.c | 2 +-
openvswitch/datapath.c | 2 ++
xfrm/xfrm_output.c | 2 ++
10 files changed, 21 insertions(+), 10 deletions(-)
next reply other threads:[~2014-10-20 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 11:49 Florian Westphal [this message]
2014-10-20 11:49 ` [PATCH v2 1/3] net: gso: use feature flag argument in all protocol gso handlers Florian Westphal
2014-10-20 11:49 ` [PATCH v2 2/3] net: make skb_gso_segment error handling more robust Florian Westphal
2014-10-20 11:49 ` [PATCH v2 3/3] net: core: handle encapsulation offloads when computing segment lengths Florian Westphal
2014-10-20 18:04 ` [PATCH v2 0/3] net: minor gso encapsulation fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413805758-30026-1-git-send-email-fw@strlen.de \
--to=fw@strlen.de \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).