From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v2 net-next 2/2] tcp: add tcpi_bytes_received to tcp_info Date: Tue, 28 Apr 2015 16:07:59 -0700 Message-ID: <1430262479.3711.5.camel@edumazet-glaptop2.roam.corp.google.com> References: <1430260098-14127-1-git-send-email-edumazet@google.com> <1430260098-14127-3-git-send-email-edumazet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , "David S. Miller" , netdev , Matt Mathis , Eric Salo , Martin Lau , Chris Rapier To: Yuchung Cheng Return-path: Received: from mail-ig0-f181.google.com ([209.85.213.181]:35516 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030966AbbD1XIE (ORCPT ); Tue, 28 Apr 2015 19:08:04 -0400 Received: by igbyr2 with SMTP id yr2so105039854igb.0 for ; Tue, 28 Apr 2015 16:08:03 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2015-04-28 at 15:56 -0700, Yuchung Cheng wrote: > Acked-by: Yuchung Cheng > Thanks ! > tho I slightly prefer to call tcp_rcv_nxt_update() when rcv_nxt is > updated in TFO for consistency. Right, but is the tp->rcv_nxt prior value even valid at this point ? :) Anyway, this would need to make tcp_rcv_nxt_update() non static and would convince compiler to not inline the code. At this point, we can simply set tp->bytes_received.