netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fan Du <fan.du@intel.com>
To: jeffrey.t.kirsher@intel.com
Cc: alexander.h.duyck@redhat.com, emil.s.tantilov@intel.com,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Fan Du <fan.du@intel.com>
Subject: [PATCH v2 3/3] ixgbe: Don't report flow director filter's status
Date: Wed, 29 Apr 2015 10:57:41 +0800	[thread overview]
Message-ID: <1430276261-29821-4-git-send-email-fan.du@intel.com> (raw)
In-Reply-To: <1430276261-29821-1-git-send-email-fan.du@intel.com>

For two reasons I want to disable this:
1. Not any part actually check the report status(Alexander Duyck)
2. To report hash value of a packet to stack,
   RSS -> 32bits hash value
   Perfect match fdir filter -> 13bits hash value
   Hashed-based fdir filter -> 31bits hash value

   fdir filter might hash on masked tuples for IP address,
   so it's still not desirable for usage.

So for now, just stick to RSS 32bits hash value.

Signed-off-by: Fan Du <fan.du@intel.com>
Suggested-by: Alexander Duyck <alexander.h.duyck@redhat.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
index e0c3639..de83b6f 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
@@ -1394,14 +1394,12 @@ s32 ixgbe_init_fdir_perfect_82599(struct ixgbe_hw *hw, u32 fdirctrl)
 	/*
 	 * Continue setup of fdirctrl register bits:
 	 *  Turn perfect match filtering on
-	 *  Report hash in RSS field of Rx wb descriptor
 	 *  Initialize the drop queue
 	 *  Move the flexible bytes to use the ethertype - shift 6 words
 	 *  Set the maximum length per hash bucket to 0xA filters
 	 *  Send interrupt when 64 (0x4 * 16) filters are left
 	 */
 	fdirctrl |= IXGBE_FDIRCTRL_PERFECT_MATCH |
-		    IXGBE_FDIRCTRL_REPORT_STATUS |
 		    (IXGBE_FDIR_DROP_QUEUE << IXGBE_FDIRCTRL_DROP_Q_SHIFT) |
 		    (0x6 << IXGBE_FDIRCTRL_FLEX_SHIFT) |
 		    (0xA << IXGBE_FDIRCTRL_MAX_LENGTH_SHIFT) |
-- 
1.7.1

  parent reply	other threads:[~2015-04-29  3:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29  2:57 [PATCH v2 0/3] RSS fix for ixgbe/ixgbevf Fan Du
2015-04-29  2:57 ` [PATCH v2 1/3] ixgbe: Specify rx hash type wrt rx desc RSS type Fan Du
2015-05-06 22:45   ` [Intel-wired-lan] " Schmitt, Phillip J
2015-04-29  2:57 ` [PATCH v2 2/3] ixgbevf: Set rx hash type for ingress packets Fan Du
2015-05-06 22:45   ` [Intel-wired-lan] " Schmitt, Phillip J
2015-04-29  2:57 ` Fan Du [this message]
2015-05-06 22:46   ` [Intel-wired-lan] [PATCH v2 3/3] ixgbe: Don't report flow director filter's status Schmitt, Phillip J
2015-04-30 12:59 ` [PATCH v2 0/3] RSS fix for ixgbe/ixgbevf Jeff Kirsher
2015-05-06 19:47   ` [Intel-wired-lan] " Schmitt, Phillip J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430276261-29821-4-git-send-email-fan.du@intel.com \
    --to=fan.du@intel.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).