From: Eric Dumazet <eric.dumazet@gmail.com>
To: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
Date: Mon, 15 Jun 2015 08:08:15 -0700 [thread overview]
Message-ID: <1434380895.27504.128.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <BL2PR03MB54503B16A47056DBA9653C0E6B80@BL2PR03MB545.namprd03.prod.outlook.com>
On Mon, 2015-06-15 at 13:40 +0000, Madalin-Cristian Bucur wrote:
> > -----Original Message-----
> > From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
> >
> > On Wed, 2015-04-29 at 17:56 +0300, Madalin Bucur wrote:
> > > This introduces the Freescale Data Path Acceleration Architecture
> > > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> > > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> > > the Freescale DPAA QorIQ platforms.
> > ...
> >
> > > + /* We're going to store the skb backpointer at the beginning
> > > + * of the data buffer, so we need a privately owned skb
> > > + */
> > > +
> > > + /* Code borrowed from skb_unshare(). */
> > > + if (skb_cloned(skb)) {
> > > + struct sk_buff *nskb = skb_copy(skb, GFP_ATOMIC);
> > > +
> > > + /* Finally, create a contig FD from this skb */
> > > + skb_to_contig_fd(priv, skb, &fd, countptr, &offset);
> > > +
> > > + kfree_skb(skb);
> > > + skb = nskb;
> > > + /* skb_copy() has now linearized the skbuff. */
> > > + }
> > > +
> >
> > You know that TCP packets are clones, right ?
> > This code is killing performance.
> >
> > TCP allows the headers part being modified by a driver if needed.
> >
> > You should use skb_header_cloned() instead.
>
> Thank you, I'll address this. I plan to do something like this:
>
> + if (!nonlinear) {
> + /* We're going to store the skb backpointer at the beginning
> + * of the data buffer, so we need a privately owned skb
> + */
> +
> + /* make sure skb is not shared, skb_cow_head() assumes it's not */
> + skb = skb_share_check(skb, GFP_ATOMIC);
> + if (!skb)
> + goto enomem;
> +
> + /* verify the skb head is not cloned */
> + if (skb_cow_head(skb, priv->tx_headroom))
> + goto enomem;
> +
> + nonlinear = skb_is_nonlinear(skb);
> + }
>
> but I'm not sure the skb_share_check() is required on tx.
> I'm also a bit puzzled by the aliasing between shared and cloned terms
> (i.e. skb_unshare() could be named something like skb_unclone();
> the skb_share_check() not only checks but also unshares an skb so
> the already taken skb_unshare() name would probably fit too).
A driver can ask tx skbs to be not shared, even if pktgen is used with
"clone=X" on it.
dev->priv_flags &= ~IFF_TX_SKB_SHARING;
This way, you can avoid skb_share_check() completely. Only pktgen will
care.
Most skb_share_check() calls in drivers/net are related to input paths
on virtual drivers.
prev parent reply other threads:[~2015-06-15 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 14:56 [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 03/10] dpaa_eth: add configurable bpool thresholds Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 04/10] dpaa_eth: add support for S/G frames Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 05/10] dpaa_eth: add driver's Tx queue selection mechanism Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 06/10] dpaa_eth: add ethtool functionality Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 07/10] dpaa_eth: add sysfs exports Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 08/10] dpaa_eth: add debugfs counters Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 09/10] dpaa_eth: add debugfs entries Madalin Bucur
2015-04-29 14:56 ` [RFC,v3 10/10] dpaa_eth: add trace points Madalin Bucur
2015-06-10 6:00 ` [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet Jianhua Xie
2015-06-10 7:38 ` Madalin-Cristian Bucur
2015-06-10 14:44 ` Eric Dumazet
2015-06-15 12:44 ` Madalin-Cristian Bucur
2015-06-10 17:56 ` Eric Dumazet
2015-06-15 13:40 ` Madalin-Cristian Bucur
2015-06-15 15:08 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434380895.27504.128.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).