From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
kernel@pengutronix.de,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 5/8] can: rcar_can: unify error messages
Date: Sun, 12 Jul 2015 21:18:08 +0200 [thread overview]
Message-ID: <1436728691-1145-6-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1436728691-1145-1-git-send-email-mkl@pengutronix.de>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
All the error messages in the driver but the ones from devm_clk_get() failures
use similar format. Make those two messages consitent with others.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/rcar_can.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/rcar_can.c b/drivers/net/can/rcar_can.c
index 5e81afffc073..7bd54191f962 100644
--- a/drivers/net/can/rcar_can.c
+++ b/drivers/net/can/rcar_can.c
@@ -785,7 +785,8 @@ static int rcar_can_probe(struct platform_device *pdev)
priv->clk = devm_clk_get(&pdev->dev, "clkp1");
if (IS_ERR(priv->clk)) {
err = PTR_ERR(priv->clk);
- dev_err(&pdev->dev, "cannot get peripheral clock: %d\n", err);
+ dev_err(&pdev->dev, "cannot get peripheral clock, error %d\n",
+ err);
goto fail_clk;
}
@@ -797,7 +798,7 @@ static int rcar_can_probe(struct platform_device *pdev)
priv->can_clk = devm_clk_get(&pdev->dev, clock_names[clock_select]);
if (IS_ERR(priv->can_clk)) {
err = PTR_ERR(priv->can_clk);
- dev_err(&pdev->dev, "cannot get CAN clock: %d\n", err);
+ dev_err(&pdev->dev, "cannot get CAN clock, error %d\n", err);
goto fail_clk;
}
--
2.1.4
next prev parent reply other threads:[~2015-07-12 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 19:18 pull-request: can 2015-07-12 Marc Kleine-Budde
2015-07-12 19:18 ` [PATCH 1/8] can: rcar_can: fix IRQ check Marc Kleine-Budde
2015-07-12 19:18 ` [PATCH 2/8] can: rcar_can: print signed IRQ # Marc Kleine-Budde
2015-07-12 19:18 ` [PATCH 3/8] can: rcar_can: fix typo in error message Marc Kleine-Budde
2015-07-12 19:18 ` [PATCH 4/8] can: rcar_can: print request_irq() error code Marc Kleine-Budde
2015-07-12 19:18 ` Marc Kleine-Budde [this message]
2015-07-12 19:18 ` [PATCH 6/8] can: c_can: Fix default pinmux glitch at init Marc Kleine-Budde
2015-07-12 19:18 ` [PATCH 7/8] ARM: dts: dra7x-evm: Prevent glitch on DCAN1 pinmux Marc Kleine-Budde
2015-07-12 19:18 ` [PATCH 8/8] can: replace timestamp as unique skb attribute Marc Kleine-Budde
2015-07-27 18:34 ` Oliver Hartkopp
2015-08-04 19:18 ` Greg KH
2015-07-13 5:24 ` pull-request: can 2015-07-12 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436728691-1145-6-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).