From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>,
Julia Lawall <julia.lawall@lip6.fr>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue
Date: Tue, 28 Jul 2015 12:18:09 +0200 [thread overview]
Message-ID: <1438078689.20182.42.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1438072868-5408-1-git-send-email-shraddha.6596@gmail.com>
On Tue, 2015-07-28 at 14:11 +0530, Shraddha Barke wrote:
> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
> ...
> if (...) {
> ...
> - continue;
> }
> }
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..91beb83 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
> if ((le16_to_cpu(dev->descriptor.idVendor)
> == hfcsusb_idtab[i].idVendor) &&
> (le16_to_cpu(dev->descriptor.idProduct)
> - == hfcsusb_idtab[i].idProduct)) {
> + == hfcsusb_idtab[i].idProduct))
> vend_idx = i;
> - continue;
> - }
> +
> }
>
> printk(KERN_DEBUG
Well, it seems author intent was to use a break instead of a continue.
Not a big deal...
next prev parent reply other threads:[~2015-07-28 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 8:41 [PATCH] Drivers: isdn: Drop unnecessary continue Shraddha Barke
2015-07-28 8:47 ` Julia Lawall
2015-07-28 10:18 ` Eric Dumazet [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-28 7:16 Shraddha Barke
2015-07-28 7:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438078689.20182.42.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).