netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eugene Shatokhin <eugene.shatokhin@rosalab.ru>
To: "Oliver Neukum" <oneukum@suse.de>, "Bjørn Mork" <bjorn@mork.no>,
	"David Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] usbnet: Fix 2 problems in usbnet_stop()
Date: Mon, 24 Aug 2015 23:13:41 +0300	[thread overview]
Message-ID: <1440447223-15945-1-git-send-email-eugene.shatokhin@rosalab.ru> (raw)
In-Reply-To: <55AD3A41.2040100@rosalab.ru>

The following problems found when investigating races in usbnet module 
are fixed here:

1. EVENT_NO_RUNTIME_PM bit of dev->flags should be read before it is 
cleared by "dev->flags = 0". Thanks to Oliver Neukum for spotting this
problem and providing a fix.

2. A race on on skb_queue between usbnet_stop() and usbnet_bh().

Compared to the combined patch I sent earlier 
("[PATCH] usbnet: Fix two races between usbnet_stop() and the BH"), this 
patch set has the following changes:

* The fix for handling of EVENT_NO_RUNTIME_PM is now in a separate patch.
* The fix for the race on dev->flags has been removed because the race is
not considered harmful.

Regards,
Eugene

  parent reply	other threads:[~2015-08-24 20:13 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 18:13 Several races in "usbnet" module (kernel 4.1.x) Eugene Shatokhin
2015-07-21 12:04 ` Oliver Neukum
     [not found]   ` <1437480243.3823.5.camel-IBi9RG/b67k@public.gmane.org>
2015-07-24 17:38     ` Eugene Shatokhin
2015-07-27 12:29       ` Oliver Neukum
2015-07-27 13:53         ` Eugene Shatokhin
2015-07-21 13:07 ` Oliver Neukum
     [not found] ` <55AD3A41.2040100-irhHPgl+04UvJsYlp49lxw@public.gmane.org>
2015-07-21 14:22   ` Oliver Neukum
2015-07-22 18:33     ` Eugene Shatokhin
2015-07-23  9:15       ` Oliver Neukum
2015-07-24 14:41         ` Eugene Shatokhin
2015-07-27 10:00           ` Oliver Neukum
2015-07-27 14:23             ` Eugene Shatokhin
2015-08-14 16:55     ` Eugene Shatokhin
2015-08-14 16:58       ` [PATCH] usbnet: Fix two races between usbnet_stop() and the BH Eugene Shatokhin
2015-08-19  1:54         ` David Miller
     [not found]           ` <20150818.185407.1667358232705414236.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-08-19  7:57             ` Eugene Shatokhin
2015-08-19 10:54               ` Bjørn Mork
2015-08-19 11:59                 ` Eugene Shatokhin
2015-08-19 12:31                   ` Bjørn Mork
2015-08-24 12:20                     ` Eugene Shatokhin
2015-08-24 13:29                       ` Bjørn Mork
2015-08-24 17:00                         ` Eugene Shatokhin
2015-08-25 12:31                         ` Oliver Neukum
2015-08-24 17:43                   ` David Miller
     [not found]                     ` <20150824.104328.554582952440857559.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-08-24 18:06                       ` Alan Stern
2015-08-24 18:21                         ` Alan Stern
2015-08-25 12:36                           ` Oliver Neukum
2015-08-24 18:35                         ` David Miller
2015-08-24 18:12                     ` Eugene Shatokhin
2015-07-23  9:43   ` Several races in "usbnet" module (kernel 4.1.x) Oliver Neukum
2015-07-23 11:39     ` Eugene Shatokhin
2015-08-24 20:13 ` Eugene Shatokhin [this message]
2015-08-24 20:13   ` [PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared Eugene Shatokhin
2015-08-25 13:01     ` Oliver Neukum
     [not found]       ` <1440507709.13824.6.camel-IBi9RG/b67k@public.gmane.org>
2015-08-25 14:16         ` Bjørn Mork
2015-08-25 14:22     ` Oliver Neukum
2015-08-26  2:44     ` David Miller
2015-08-24 20:13   ` [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH Eugene Shatokhin
2015-08-24 21:01     ` Bjørn Mork
2015-08-28  8:09       ` Eugene Shatokhin
2015-08-28  8:55         ` Bjørn Mork
2015-08-28 10:42           ` Eugene Shatokhin
2015-08-31  7:32             ` Bjørn Mork
2015-08-31  8:50               ` Eugene Shatokhin
2015-09-01  7:58                 ` Oliver Neukum
2015-09-01 13:54                   ` Eugene Shatokhin
2015-09-01 14:05                   ` [PATCH] " Eugene Shatokhin
2015-09-08  7:24                     ` Eugene Shatokhin
2015-09-08  7:37                       ` Bjørn Mork
2015-09-08  7:48                         ` Oliver Neukum
2015-09-08 20:18                     ` David Miller
2015-09-01  7:57         ` [PATCH 2/2] " Oliver Neukum
2015-08-26  2:45     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440447223-15945-1-git-send-email-eugene.shatokhin@rosalab.ru \
    --to=eugene.shatokhin@rosalab.ru \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).