From: Vikas Bansal <vikas.bansal@samsung.com>
To: oneukum@suse.de, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: sumit.batra@samsung.com, Vikas Bansal <vikas.bansal@samsung.com>
Subject: [PATCH] Adding Reset resume support for CDC-EEM driver.
Date: Mon, 21 Dec 2015 17:38:51 +0530 [thread overview]
Message-ID: <1450699731-4666-1-git-send-email-vikas.bansal@samsung.com> (raw)
Pre-Condition
At the time of reset resume of a USB device, both self and bus powered devices might go to a low power state or power off state depending on the acceptable suspend time power of the system.
In case the device experiences a power glitch or completely powers off during suspend-resume, the device will lose its internal state and hence it'll again need a set interface from class driver on reset resume operation.
Issue
So far our experiments were based on a USB gadget working on cdc_eem protocol.
We have seen that device is unable to continue the packet transfer on bulk endpoints after the reset resume operation.
Solution
We have added a .reset_resume function for cdc_eem protocol which sends a set interface command on the Control endpoint. And calls the existing usbnet_resume thereafter
Signed-off-by: Vikas Bansal <vikas.bansal@samsung.com>
Signed-off-by: Sumit Batra <sumit.batra@samsung.com>
diff --git a/drivers/net/usb/cdc_eem.c b/drivers/net/usb/cdc_eem.c
index f7180f8..1f6f7ea 100644
--- a/drivers/net/usb/cdc_eem.c
+++ b/drivers/net/usb/cdc_eem.c
@@ -342,6 +342,19 @@ next:
return 1;
}
+static int cdc_eem_resume(struct usb_interface *intf)
+{
+ int ret = 0;
+ struct usbnet *dev = usb_get_intfdata(intf);
+
+ ret = usbnet_get_endpoints(dev, intf);
+ if(ret < 0)
+ goto err;
+ ret = usbnet_resume(intf);
+err:
+ return ret;
+}
+
static const struct driver_info eem_info = {
.description = "CDC EEM Device",
.flags = FLAG_ETHER | FLAG_POINTTOPOINT,
@@ -371,6 +384,7 @@ static struct usb_driver eem_driver = {
.disconnect = usbnet_disconnect,
.suspend = usbnet_suspend,
.resume = usbnet_resume,
+ .reset_resume = cdc_eem_resume,
.disable_hub_initiated_lpm = 1,
};
next reply other threads:[~2015-12-21 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 12:08 Vikas Bansal [this message]
2015-12-21 15:56 ` [PATCH] Adding Reset resume support for CDC-EEM driver Alan Stern
2015-12-21 13:04 Vikas Bansal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450699731-4666-1-git-send-email-vikas.bansal@samsung.com \
--to=vikas.bansal@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=sumit.batra@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).