From: Lorenzo Colitti <lorenzo@google.com>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, eric.dumazet@gmail.com,
zenczykowski@gmail.com
Subject: Re: [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY.
Date: Tue, 22 Dec 2015 17:31:32 +0900 [thread overview]
Message-ID: <1450773094-7978-1-git-send-email-lorenzo@google.com> (raw)
In-Reply-To: <20151221214222.5ee87383@xeon-e3>
I've just uploaded a new version. The changes from v2 are as
follows:
- Removed the superfluous inline keyword.
- The code now ignores ENOENT from kill_inet_sock. This can
happen if something else closed the socket during the scan, or
if the user requests killing a socket that is not in the hash
tables and thus cannot be found by inet_diag_find_one_icsk.
- The semantics of rtnl_send_check_ack are clearer. If the caller
passes in ack=1, the function blocks until a response is
received (unlike v2 which passed in MSG_PEEK). Also, an
NLMSG_ERROR with an err of 0 is not treated as a failure.
- kill_inet_sock always requests an ACK when closing a socket.
This version is also tested on real hardware. The following work:
- Passing in -K as non-root immediately stops with EPERM.
- Running "ss -a -K dport = :22" closes SSH.
- Running ss -a -K dport = :5222 closes my XMPP connections,
interrupts my chat client, and sends RSTs to the server.
- The above command silently skips TIME_WAIT sockets, which
cannot be destroyed, without interrupting the dump.
next prev parent reply other threads:[~2015-12-22 8:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 13:22 [iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs Lorenzo Colitti
2015-12-17 13:22 ` [iproute PATCH v2 2/2] ss: support closing inet sockets via SOCK_DESTROY Lorenzo Colitti
2015-12-17 15:29 ` Eric Dumazet
2015-12-22 5:42 ` Stephen Hemminger
2015-12-22 8:31 ` Lorenzo Colitti [this message]
2015-12-22 8:31 ` [iproute PATCH v3 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs Lorenzo Colitti
2015-12-23 21:17 ` Stephen Hemminger
2015-12-22 8:31 ` [iproute PATCH v3 2/2] ss: support closing inet sockets via SOCK_DESTROY Lorenzo Colitti
2015-12-30 20:34 ` Stephen Hemminger
2016-01-04 1:54 ` Lorenzo Colitti
2016-01-08 8:32 ` Lorenzo Colitti
2016-01-08 8:32 ` [iproute PATCH v4 1/2] libnetlink: don't print NETLINK_SOCK_DIAG errors in rtnl_talk Lorenzo Colitti
2016-01-08 8:32 ` [iproute PATCH v4 2/2] ss: support closing inet sockets via SOCK_DESTROY Lorenzo Colitti
2016-01-18 19:48 ` Stephen Hemminger
2015-12-22 8:35 ` [iproute PATCH v2 " Lorenzo Colitti
2015-12-17 16:07 ` [iproute PATCH v2 1/2] libnetlink: add a variant of rtnl_send_check that consumes ACKs Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450773094-7978-1-git-send-email-lorenzo@google.com \
--to=lorenzo@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).