From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: David Miller <davem@davemloft.net>,
Hayes Wang <hayeswang@realtek.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Grant Grundler <grundler@chromium.org>,
Mario Limonciello <mario.limonciello@dell.com>,
David Chen <david.chen7@dell.com>,
"open list:USB NETWORKING DRIVERS" <linux-usb@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] r8152: Add MAC passthrough support to new device
Date: Tue, 14 Jan 2020 16:03:50 +0800 [thread overview]
Message-ID: <14A65209-846C-4C94-9EC3-55605D2528B0@canonical.com> (raw)
In-Reply-To: <CACeCKacQpDsptRi6AZhuFYg2c87-bW0KS6vy=CacB8+j+6YBXA@mail.gmail.com>
> On Jan 14, 2020, at 15:51, Prashant Malani <pmalani@chromium.org> wrote:
>
> On Mon, Jan 13, 2020 at 8:41 PM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
>>
>> Device 0xa387 also supports MAC passthrough, therefore add it to the
>> whitelst.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1827961/comments/30
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> drivers/net/usb/r8152.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
>> index c5ebf35d2488..42dcf1442cc0 100644
>> --- a/drivers/net/usb/r8152.c
>> +++ b/drivers/net/usb/r8152.c
>> @@ -6657,7 +6657,8 @@ static int rtl8152_probe(struct usb_interface *intf,
>> }
>>
>> if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO &&
>> - le16_to_cpu(udev->descriptor.idProduct) == 0x3082)
>> + (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 ||
>> + le16_to_cpu(udev->descriptor.idProduct) == 0xa387))
> Perhaps we can try to use #define's for these vendor IDs (like
> https://github.com/torvalds/linux/blob/master/drivers/net/usb/r8152.c#L680)
> ?
We can, but it'll bring some inconsistencies inside of rtl8152_table[], since we don't know idProduct for other devices.
Kai-Heng
>
>> set_bit(LENOVO_MACPASSTHRU, &tp->flags);
>>
>> if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial &&
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2020-01-14 8:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 4:41 [PATCH] r8152: Add MAC passthrough support to new device Kai-Heng Feng
2020-01-14 7:51 ` Prashant Malani
2020-01-14 8:03 ` Kai-Heng Feng [this message]
2020-01-14 8:23 ` Oliver Neukum
2020-01-14 9:22 ` Kai-Heng Feng
2020-01-14 20:33 ` Mario.Limonciello
2020-01-15 6:40 ` Kai Heng Feng
2020-01-15 7:04 ` Hayes Wang
2020-01-15 6:19 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14A65209-846C-4C94-9EC3-55605D2528B0@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=davem@davemloft.net \
--cc=david.chen7@dell.com \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).