From: Edward Cree <ecree@solarflare.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
"Andy Gospodarek" <andy@greyhouse.net>,
Michael Chan <michael.chan@broadcom.com>,
Vishal Kulkarni <vishal@chelsio.com>
Subject: Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics
Date: Fri, 24 May 2019 14:57:24 +0100 [thread overview]
Message-ID: <1506061d-6ced-4ca2-43fa-09dad30dc7e6@solarflare.com> (raw)
In-Reply-To: <bf4c9a41-ea81-4d87-2731-372e93f8d53d@solarflare.com>
On 24/05/2019 14:09, Edward Cree wrote:
> I'll put together an RFC patch, anyway
Argh, there's a problem: an action doesn't have a (directly) associated
block, and all the TC offload machinery nowadays is built around blocks.
Since this action might have been used in _any_ block (and afaik there's
no way, from the action, to find which) we'd have to make callbacks on
_every_ block in the system, which sounds like it'd perform even worse
than the rule-dumping approach.
Any ideas?
-Ed
next prev parent reply other threads:[~2019-05-24 13:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 21:37 [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics Edward Cree
2019-05-22 21:38 ` [PATCH v3 net-next 1/3] flow_offload: add a cookie to flow_action_entry Edward Cree
2019-05-22 21:38 ` [PATCH v3 net-next 2/3] flow_offload: restore ability to collect separate stats per action Edward Cree
2019-05-22 21:38 ` [PATCH v3 net-next 3/3] flow_offload: include linux/kernel.h from flow_offload.h Edward Cree
2019-05-22 22:20 ` [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics Jakub Kicinski
2019-05-23 13:19 ` Jamal Hadi Salim
2019-05-23 16:11 ` Jakub Kicinski
2019-05-23 16:40 ` Edward Cree
2019-05-23 17:25 ` Jakub Kicinski
2019-05-24 13:09 ` Edward Cree
2019-05-24 13:57 ` Edward Cree [this message]
2019-05-24 14:44 ` Jamal Hadi Salim
2019-05-24 15:09 ` Edward Cree
2019-05-24 17:59 ` Jamal Hadi Salim
2019-05-24 17:03 ` Jakub Kicinski
2019-05-24 17:27 ` Edward Cree
2019-05-24 17:44 ` Jakub Kicinski
2019-05-28 16:27 ` Edward Cree
2019-05-29 20:07 ` [RFC PATCH net-next 0/2] RTM_GETACTION stats offload Edward Cree
2019-05-29 20:10 ` [RFC PATCH net-next 1/2] net/sched: add callback to get stats on an action from clsflower offload Edward Cree
2019-05-29 20:11 ` [RFC PATCH net-next 2/2] net/sched: add action block binding to other classifiers Edward Cree
2019-05-23 16:21 ` [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics Edward Cree
2019-05-23 16:33 ` Jakub Kicinski
2019-05-23 17:09 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506061d-6ced-4ca2-43fa-09dad30dc7e6@solarflare.com \
--to=ecree@solarflare.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vishal@chelsio.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).