From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65444C433E1 for ; Thu, 9 Jul 2020 02:14:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4187520739 for ; Thu, 9 Jul 2020 02:14:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HsjeMImM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgGICN7 (ORCPT ); Wed, 8 Jul 2020 22:13:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbgGICN6 (ORCPT ); Wed, 8 Jul 2020 22:13:58 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ED55C061A0B for ; Wed, 8 Jul 2020 19:13:58 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id cv18so2747042pjb.1 for ; Wed, 08 Jul 2020 19:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vLYNK3Az17O1iTYhpPu4P8kQCbruyaUYCoCCV1Y1vfA=; b=HsjeMImMuIInLLTVkCQRcvKOmOMDlDfCT5gQyCdzMqsCX8Yu2maADTH5fGrr43bQju qpTxJRsb3sfaQdQtMc7DQDpdrGwxSjXFRhWN4lqAgsJaJD/pmYr0sYvp/mpYz5im3lib FmaUn368avXjG+TT1dyc7TzcVCUdcQ9avf0x/XvyFKtblbyKh0JAvkflm5+SMgr2VgWK ZmaTWFirrnjic+c8ZEm99MrSzaf21xHzdTzQTYRPwUVtHUzrvWpvjeaPve/1j0yT3pTx Yd2ONHKl0tmYafwEVbu4c4CT843hjah8GZ/A5azMmY4XTiEaJAQhRqxNaiw3JGe44J/u p5Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vLYNK3Az17O1iTYhpPu4P8kQCbruyaUYCoCCV1Y1vfA=; b=VlKiLI98o8ZiIRwJuLUebOe/Azm1J0lDcayWtqA7Oh7nBPOgOOVFLQgbXKEhRybvP7 NCpLanxZgPdy9RNHtphI3KiJ/M4bqiLX7SgfQmyAOSWG7/UYBSGVrkqsAhiKji/OG2cL wLOzv9AlsvmIZUCQTXktlBd7PrS9nXM5zZ15PdsA8UUFP4QxpNBCKYDl2YdX+0WFLZw1 uqzEZ4HwDpPbUbAljZxb+Abd2iY4jWLwnZiqyou97xx2n7hw/c7eP9B8QYOVlgGsYyGy AxBy+ftfLiUHFM8MKevKDQ7CAi+N7XGwVmI2W/TOR3x/73fM/+Z1a+3Qfjm+KjQ+NiVC zD5g== X-Gm-Message-State: AOAM530MCplzIFsgzUTtL6weVviNTJPyAqqpRoTuUgFI3YSXIUOBxcON 63i+gUQTewDdSGPcc98E6Mo= X-Google-Smtp-Source: ABdhPJzaOlkJS194w/G6zLI3r4PANOrEhCvTxjqu4b8FXMH04geBJCeg2QtY62mo+eWhH6VnC/TeQw== X-Received: by 2002:a17:902:ee14:: with SMTP id z20mr11646452plb.265.1594260837979; Wed, 08 Jul 2020 19:13:57 -0700 (PDT) Received: from ?IPv6:2001:470:67:5b9:5dec:e971:4cde:a128? ([2001:470:67:5b9:5dec:e971:4cde:a128]) by smtp.gmail.com with ESMTPSA id b82sm896358pfb.215.2020.07.08.19.13.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 19:13:57 -0700 (PDT) Subject: Re: [net-next PATCH 1/3 v1] net: dsa: rtl8366: Fix VLAN semantics To: Linus Walleij , Andrew Lunn , Vivien Didelot , netdev@vger.kernel.org, "David S . Miller" Cc: DENG Qingfang , Mauri Sandberg References: <20200708204456.1365855-1-linus.walleij@linaro.org> <20200708204456.1365855-2-linus.walleij@linaro.org> From: Florian Fainelli Message-ID: <15074ccd-97de-7417-4d11-3d1bcaf4c70d@gmail.com> Date: Wed, 8 Jul 2020 19:13:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200708204456.1365855-2-linus.walleij@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/8/2020 1:44 PM, Linus Walleij wrote: > The RTL8366 would not handle adding new members (ports) to > a VLAN: the code assumed that ->port_vlan_add() was only > called once for a single port. When intializing the > switch with .configure_vlan_while_not_filtering set to > true, the function is called numerous times for adding > all ports to VLAN1, which was something the code could > not handle. > > Alter rtl8366_set_vlan() to just |= new members and > untagged flags to 4k and MC VLAN table entries alike. > This makes it possible to just add new ports to a > VLAN. > > Put in some helpful debug code that can be used to find > any further bugs here. > > Cc: DENG Qingfang > Cc: Mauri Sandberg > Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") > Signed-off-by: Linus Walleij Reviewed-by: Florian Fainelli -- Florian