From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexei Starovoitov <ast@fb.com>, Lawrence Brakmo <brakmo@fb.com>,
netdev <netdev@vger.kernel.org>
Cc: Kernel Team <kernel-team@fb.com>, Blake Matheny <bmatheny@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks
Date: Wed, 24 Jan 2018 08:58:09 -0800 [thread overview]
Message-ID: <1516813089.3715.22.camel@gmail.com> (raw)
In-Reply-To: <083f1629-31f0-4903-2213-b98d7ebc3e84@fb.com>
On Wed, 2018-01-24 at 08:48 -0800, Alexei Starovoitov wrote:
> On 1/24/18 7:48 AM, Eric Dumazet wrote:
> > On Wed, 2018-01-24 at 07:27 -0800, Alexei Starovoitov wrote:
> > >
> > > Most of the time, Yes, but it's the other way around this time.
> > > I specifically asked Larry to do it this way, since net tree is
> > > practically closed (only critical fixes allowed).
> > > When 4.15 is released on Sunday we'll send this patch
> > > independently to 4.15 and 4.14
> > >
> >
> > How hard would it be to put the fix first in the series then ?
> > If this proves complex, then maybe we have a bigger problem.
>
> you mean to put patch 4 to be first in the series ?
> I don't think that matters. It applies fine as-is on net tree
> and builds without issues. I only need to double check that
> nothing else needed before adding it to stable queue.
Yes, this is exactly what we need.
We had a major issue with this bug, and we are lucky that we disabled
unpriv eBPF for other reasons.
prev parent reply other threads:[~2018-01-24 16:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 7:57 [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 01/12] bpf: Make SOCK_OPS_GET_TCP size independent Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 02/12] bpf: Make SOCK_OPS_GET_TCP struct independent Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 03/12] bpf: Add write access to tcp_sock and sock fields Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 04/12] bpf: Only reply field should be writeable Lawrence Brakmo
2018-01-24 19:58 ` Yuchung Cheng
2018-01-24 20:23 ` Alexei Starovoitov
2018-01-24 7:57 ` [PATCH bpf-next v8 05/12] bpf: Support passing args to sock_ops bpf function Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 06/12] bpf: Adds field bpf_sock_ops_cb_flags to tcp_sock Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 07/12] bpf: Add sock_ops RTO callback Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 08/12] bpf: Add support for reading sk_state and more Lawrence Brakmo
2018-01-24 20:05 ` Yuchung Cheng
2018-01-24 22:07 ` Lawrence Brakmo
2018-01-24 7:57 ` [PATCH bpf-next v8 09/12] bpf: Add sock_ops R/W access to tclass Lawrence Brakmo
2018-01-24 7:58 ` [PATCH bpf-next v8 10/12] bpf: Add BPF_SOCK_OPS_RETRANS_CB Lawrence Brakmo
2018-01-24 20:01 ` Yuchung Cheng
2018-01-24 21:14 ` Lawrence Brakmo
2018-01-24 7:58 ` [PATCH bpf-next v8 11/12] bpf: Add BPF_SOCK_OPS_STATE_CB Lawrence Brakmo
2018-01-24 7:58 ` [PATCH bpf-next v8 12/12] bpf: add selftest for tcpbpf Lawrence Brakmo
2018-01-24 14:14 ` [PATCH bpf-next v8 00/12] bpf: More sock_ops callbacks Eric Dumazet
2018-01-24 15:27 ` Alexei Starovoitov
2018-01-24 15:48 ` Eric Dumazet
2018-01-24 16:48 ` Alexei Starovoitov
2018-01-24 16:58 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516813089.3715.22.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=ast@fb.com \
--cc=bmatheny@fb.com \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).